You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what you want implemented
When asserting that a point is equal a public point in-circuit, the coordinates of the public point are appended to the circuit is their negative form while they should be positive.
The fix requires to change append_equal_constant to append the constant in it's positive form as well.
Describe "Why" this is needed
Appending public inputs negatively is confusing and can lead to the verifier rejecting a perfectly fine proof simply because the verifier expected the public inputs to be positive.
Describe what you want implemented
When asserting that a point is equal a public point in-circuit, the coordinates of the public point are appended to the circuit is their negative form while they should be positive.
The fix requires to change
append_equal_constant
to append the constant in it's positive form as well.Describe "Why" this is needed
Appending public inputs negatively is confusing and can lead to the verifier rejecting a perfectly fine proof simply because the verifier expected the public inputs to be positive.
Describe alternatives you've considered
N/A
Additional context
see issue #717
The text was updated successfully, but these errors were encountered: