Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negation of public input in assert_equal_public_point #728

Closed
moCello opened this issue Jan 25, 2023 · 0 comments · Fixed by #730
Closed

Fix negation of public input in assert_equal_public_point #728

moCello opened this issue Jan 25, 2023 · 0 comments · Fixed by #730
Assignees
Labels
team:Core Low Level Core Development Team (Rust) team:research

Comments

@moCello
Copy link
Member

moCello commented Jan 25, 2023

Describe what you want implemented
When asserting that a point is equal a public point in-circuit, the coordinates of the public point are appended to the circuit is their negative form while they should be positive.

The fix requires to change append_equal_constant to append the constant in it's positive form as well.

Describe "Why" this is needed
Appending public inputs negatively is confusing and can lead to the verifier rejecting a perfectly fine proof simply because the verifier expected the public inputs to be positive.

Describe alternatives you've considered
N/A

Additional context
see issue #717

@moCello moCello added team:Core Low Level Core Development Team (Rust) team:research labels Jan 25, 2023
@moCello moCello self-assigned this Jan 25, 2023
moCello added a commit that referenced this issue Jan 26, 2023
This change also required to change the negation of the constant
in `append_equal_constant`.
Tests added as well.

Resolves #728
moCello added a commit that referenced this issue Jan 26, 2023
This change also required to change the negation of the constant
in `append_equal_constant`.
Tests added as well.

Resolves #728
@moCello moCello mentioned this issue Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:Core Low Level Core Development Team (Rust) team:research
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant