Fix negation of coordinates in assert_equal_public_point
#730
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 85.07% 85.03% -0.05%
==========================================
Files 47 47
Lines 3879 3922 +43
==========================================
+ Hits 3300 3335 +35
- Misses 579 587 +8
Continue to review full report at Codecov.
|
This change also required to change the negation of the constant in `append_equal_constant`. Tests added as well. Resolves #728
moCello
force-pushed
the
mocello/ecc_tests
branch
from
b856d7d
to
564ce2a
Compare
tests/ecc.rs
Outdated
| // Test: | ||
| // GENERATOR != 42 * GENERATOR | ||
| { | ||
| let scalar = JubJubScalar::from(42u64); | ||
| let point = dusk_jubjub::GENERATOR; | ||
| let public = dusk_jubjub::GENERATOR_EXTENDED * &scalar; | ||
| let circuit = DummyCircuit::new(point, public.into()); | ||
|
|
||
| prover | ||
| .prove(rng, &circuit) | ||
| .expect_err("prover should fail because the points are not equal"); | ||
| } |
There was a problem hiding this comment.
I think it might be better to make these scopes a function that gets called with different points. Something like:
fn prove_equal_points(point: JubJubAffine, public: JubJubAffine) -> Result<(Proof, Vec<BlsScalar>), Error> {
let circuit = DummyCircuit::new();
prover.prove(rng, &circuit)
}There was a problem hiding this comment.
that would mean cloning the prover and verifier for each of these functions. i think it's a bit of an overkill. But it might work with references. I'll give it some thought
There was a problem hiding this comment.
naah, it would need two functions per TestCircuit, one for testing a satisfied circuit and one for testing an unsatisfied circuit and I also want to have custom failure messages for each test case. I think it wouldn't make things easier to read in the end. Also the TestCircuit itself doesn't exist outside of the test function etc... too complicated
This change also required to change the negation of the constant in
append_equal_constant.Tests added as well.
Resolves #728