Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProverKey::serialization_size #743

Closed
moCello opened this issue Feb 27, 2023 · 0 comments · Fixed by #744
Closed

Fix ProverKey::serialization_size #743

moCello opened this issue Feb 27, 2023 · 0 comments · Fixed by #744
Assignees

Comments

@moCello
Copy link
Member

moCello commented Feb 27, 2023

Describe what you want implemented
With the change from plonkup back to plonk #684 in the serialization size of the proverkey the poly_num were not adapted correctly, causing the serialization size to be bigger than needed.
Additionally the number of coefficients in a constraint also weren't updated. There used to be 13 coefficients but now that the lookupgate is gone, there are only 12 coefficients in a constraint.

Describe "Why" this is needed
The serialization size was bigger than it needed to be. While the other way round would have much worse implications, this is still to be fixed.

Describe alternatives you've considered
N/A

Additional context
N/A

@moCello moCello self-assigned this Feb 27, 2023
moCello added a commit that referenced this issue Feb 27, 2023
moCello added a commit that referenced this issue Mar 13, 2023
@moCello moCello mentioned this issue Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant