Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the crate to the piecrust-enabled ABI #74

Closed
wants to merge 12 commits into from
Closed

Port the crate to the piecrust-enabled ABI #74

wants to merge 12 commits into from

Conversation

ureeves
Copy link
Member

@ureeves ureeves commented Jan 19, 2023

Resolves #69
Resolves #70

@ureeves ureeves force-pushed the piecrust branch 3 times, most recently from 5327005 to 47f22a1 Compare January 20, 2023 14:49
@ureeves ureeves marked this pull request as ready for review February 1, 2023 00:50
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I propose someone more familiar with the crate to also have a look

@herr-seppia herr-seppia self-assigned this Feb 3, 2023
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Overall

  • A question to be addressed (the naming one) before approve
  • The rest is optional

src/imp.rs Outdated Show resolved Hide resolved
src/imp.rs Outdated Show resolved Hide resolved
src/tx.rs Outdated Show resolved Hide resolved
src/tx.rs Show resolved Hide resolved
Copy link
Member

@herr-seppia herr-seppia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ad discussed I am going to approve under the condition that the nomenclature comment is addressed

@ureeves ureeves force-pushed the piecrust branch 2 times, most recently from 1b915f5 to 5729a24 Compare February 6, 2023 17:11
- Add `Error::Utf8` variant
- Change `UnprovenTransaction` serialization to no longer use
  `canonical`
- Change `Error::Canon` variant to `Error::Rkyv`
- Remove `Transaction` and `TransactionSkeleton`
- Remove `canonical` dependency
- Add `rkyv` dependency
- Update dependencies to latest versions

Resolves #69
Resolves #70
@ureeves
Copy link
Member Author

ureeves commented Jun 13, 2023

This is blocked by the release of a rusk-abi version compatible with dusk-network/piecrust#223

dusk-poseidon = { version = "0.29.1-rc.0", default-features = false }
dusk-merkle = { version = "0.4.1-rc.0", features = ["poseidon", "rkyv-impl"] }
dusk-plonk = { version = "0.13", default-features = false }
rusk-abi = { version = "0.8.0-piecrust.0.5", features = ["host"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ureeves is this still required?

cc @ZER0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "host" feature will cease to be required when I complete the port of rusk-abi to piecrust@0.6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@ureeves
Copy link
Member Author

ureeves commented Jul 6, 2023

Irrelevant since #77 and #78 were merged

@ureeves ureeves closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TransactionSkeleton Port to be compatible with piecrust contract
3 participants