-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the crate to the piecrust
-enabled ABI
#74
Conversation
5327005
to
47f22a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I propose someone more familiar with the crate to also have a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Overall
- A question to be addressed (the naming one) before approve
- The rest is optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ad discussed I am going to approve under the condition that the nomenclature comment is addressed
1b915f5
to
5729a24
Compare
- Add `Error::Utf8` variant - Change `UnprovenTransaction` serialization to no longer use `canonical` - Change `Error::Canon` variant to `Error::Rkyv` - Remove `Transaction` and `TransactionSkeleton` - Remove `canonical` dependency - Add `rkyv` dependency - Update dependencies to latest versions Resolves #69 Resolves #70
This is blocked by the release of a |
dusk-poseidon = { version = "0.29.1-rc.0", default-features = false } | ||
dusk-merkle = { version = "0.4.1-rc.0", features = ["poseidon", "rkyv-impl"] } | ||
dusk-plonk = { version = "0.13", default-features = false } | ||
rusk-abi = { version = "0.8.0-piecrust.0.5", features = ["host"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "host" feature will cease to be required when I complete the port of rusk-abi
to piecrust@0.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
…rc.0 Release 0.18.0-piecrust.0.5
Resolves #69
Resolves #70