Port the crate to the piecrust-enabled ABI
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 17, 2023 21:48
- Add `Error::Utf8` variant - Change `UnprovenTransaction` serialization to no longer use `canonical` - Change `Error::Canon` variant to `Error::Rkyv` - Remove `Transaction` and `TransactionSkeleton` - Remove `canonical` dependency - Add `rkyv` dependency - Update dependencies to latest versions Resolves #69 Resolves #70
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 63.53% 73.12% +9.58%
==========================================
Files 3 3
Lines 724 573 -151
==========================================
- Hits 460 419 -41
+ Misses 264 154 -110
Continue to review full report in Codecov by Sentry.
|
fed-franz
approved these changes
Jul 4, 2023
HDauven
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #74, using a version of
rusk-abithat doesn't bring inpiecrustin the dependency tree. We should likely rebase the previous PR's branch on top of this one, since it contains modifications required for the newest version of plonk.Resolves #69
Resolves #70