Fix path #416
Merged
Fix path #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspacca
reviewed
Oct 8, 2021
server/handlers.go
Outdated
| @@ -286,7 +288,7 @@ func (s *Server) notFoundHandler(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| func sanitize(fileName string) string { | |||
| return path.Clean(path.Base(fileName)) | |||
| return filepath.Base(fileName) | |||
There was a problem hiding this comment.
this seems to change the behaviour:
https://pkg.go.dev/path#Clean
https://pkg.go.dev/path/filepath#Base
It might be that's not what we need.
Can you clarify if it's an actual bug and provide steps to reproduce it?
Thanks
There was a problem hiding this comment.
I don't understand why you call path.Clean.
There was a problem hiding this comment.
yes, sorry, I mislooked the fact that we apply path.Clean after path.Base
The path package should only be used for paths separated by forward slashes, such as the paths in URLs. This package does not deal with Windows paths with drive letters or backslashes; to manipulate operating system paths, use the path/filepath package.
I think path package is a better option here rather than filepath because the input is a URL path.
What do you think?
In case you agree you can remove path.Clean and keep only path.Base
There was a problem hiding this comment.
Thanks your explaining. Updated.
aspacca
approved these changes
Oct 10, 2021
GanZhiXiong
added a commit
to GanZhiXiong/transfer.sh
that referenced
this pull request
Nov 10, 2021
…ch-1 * 'patch-1' of github.com:GanZhiXiong/transfer.sh: issue dutchcoders#420 added MaxDate.IsZero() check (dutchcoders#427) fix go1.16, add go1.17 bump bluemonday Revert "issue dutchcoders#420 return 400 response when Max-Days is too big (dutchcoders#422)" (dutchcoders#426) issue dutchcoders#420 return 400 response when Max-Days is too big (dutchcoders#422) Implement Nix Flake (dutchcoders#424) fix missed errors (dutchcoders#417) Fix path (dutchcoders#416) Edited code of condunct for more information and corrected a grammatical error (dutchcoders#421) Update README.md (dutchcoders#415) Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.