issue #420 return 400 response when Max-Days is too big

[kugiyasan]

No description provided.

[aspacca]

@kugiyasan thanks for trying to solve the issue, but this doesn't seem the proper solution.
I still have to understand what's exactly the bug: and integer overflow or a problem in the check for the max date constraint.

your code doesn't fix either of them: also the metadata are saved anyway even if the max date is "wrong"

[kugiyasan]

Oh sorry, I jumped the gun and forgot to explain!

I played around with a local server, and Max-Days: 100000 is valid, while Max-Days: 110000 is invalid. Looking at the source code, this header is converted to an int and is then passed to time.Duration. time.Duration's documentation says that:

The representation limits the largest representable duration to approximately 290 years.

which explains why 100000 days (around 274 years) works but 110000 days (301 years) fails.

Personally I prefer the 400 response. but both numbers aren't logically speaking "invalid", so should we simply silently ignore Max-Days bigger than 106752 days so that the uploaded file acts like it has no expired date?

[kugiyasan]

Oops, sorry @aspacca, the tests were passing and I merged the main branch, can you re-run the tests and merge please?