Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help and text for errors placed incorrectly #12

Open
dvdsk opened this issue Aug 31, 2022 · 1 comment
Open

Help and text for errors placed incorrectly #12

dvdsk opened this issue Aug 31, 2022 · 1 comment
Assignees
Labels
bug Something isn't working Stable only Will resolve when a feature stablizes

Comments

@dvdsk
Copy link
Owner

dvdsk commented Aug 31, 2022

Could not reproduce locally however got one error report in private (pop-os alacritty bash). Its reproduced by Github CI. Should take this up with maintainer of proc-macro-error.

@dvdsk dvdsk added the bug Something isn't working label Aug 31, 2022
@dvdsk dvdsk self-assigned this Aug 31, 2022
@dvdsk
Copy link
Owner Author

dvdsk commented Sep 1, 2022

Issue occurs only on stable. Probably because proc-macro-error can not use the diagnostics API on stable. I expect this issue to disappear when it stabilizes, at which point we might be able to drop the dependency on proc-macro-error.

@dvdsk dvdsk added the Stable only Will resolve when a feature stablizes label Sep 1, 2022
dvdsk added a commit that referenced this issue Sep 1, 2022
adresses #13 and #12, joining spans no longer chrashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stable only Will resolve when a feature stablizes
Projects
None yet
Development

No branches or pull requests

1 participant