Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spans incorrect for map wrapper & backend err #13

Open
dvdsk opened this issue Sep 1, 2022 · 1 comment
Open

Spans incorrect for map wrapper & backend err #13

dvdsk opened this issue Sep 1, 2022 · 1 comment
Assignees
Labels
bug Something isn't working Stable only Will resolve when a feature stablizes

Comments

@dvdsk
Copy link
Owner

dvdsk commented Sep 1, 2022

Occurs on stable only.

Since Span.join() is still unstable we can not join multiple spans.

On stable:

  • when wrapping map the call site span is used. That means that any errors relating to the key or value types (such as not implementing serde::Serialize) become hard to debug.
  • when two back ends are specified (not allowed) only the second gets a span in the error.

This will be solved when proc_macro stablizes the join method.

@dvdsk dvdsk added the bug Something isn't working label Sep 1, 2022
@dvdsk dvdsk self-assigned this Sep 1, 2022
@dvdsk dvdsk added the Stable only Will resolve when a feature stablizes label Sep 1, 2022
dvdsk added a commit that referenced this issue Sep 1, 2022
adresses #13 and #12, joining spans no longer chrashes
@dvdsk
Copy link
Owner Author

dvdsk commented Jan 31, 2025

Span::join tracking issue: rust-lang/rust#54725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stable only Will resolve when a feature stablizes
Projects
None yet
Development

No branches or pull requests

1 participant