Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old versions of files appear #38

Closed
mhkeller opened this issue Feb 7, 2022 · 5 comments · Fixed by #52
Closed

Old versions of files appear #38

mhkeller opened this issue Feb 7, 2022 · 5 comments · Fixed by #52
Assignees
@dvirtz
Labels
enhancement New feature or request

Comments

@mhkeller
Copy link

mhkeller commented Feb 7, 2022

When I rewrite a previously viewed file, I see the old version, not what I just overwrote it with.
@dvirtz
Copy link
Owner

dvirtz commented Feb 8, 2022

Thanks for opening the issue.

The view is cached for performance reasons. I'll see what I can do to invalidate the cache when the underlying file changes.
In the meantime, reloading the window (Developer: Reload Window command) should help.

@dvirtz dvirtz self-assigned this Feb 8, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 10, 2022
@dvirtz
Copy link
Owner

dvirtz commented Mar 10, 2022

still working on that

@dvirtz dvirtz added enhancement New feature or request and removed Stale labels Mar 10, 2022
@karimelghazouly
Copy link

same issue here, this costed me around 2 hours of debugging trying to figure out why the new file has not changed.

@dvirtz
Copy link
Owner

dvirtz commented Jun 2, 2022

Sorry about your time loss.
Unfortunately, I hadn't time to work on that. PRs are welcome.

dvirtz added a commit that referenced this issue Jun 19, 2022
@dvirtz
feat: watch for file changes
39fb2d9 
closes: Old versions of files appear #38
@dvirtz dvirtz mentioned this issue Jun 19, 2022
Merged
@dvirtz dvirtz linked a pull request Jun 19, 2022 that will close this issue
feat: watch for file changes #52
Merged
dvirtz added a commit that referenced this issue Jun 20, 2022
@dvirtz
feat: watch for file changes
60b88d9 
closes: Old versions of files appear #38
dvirtz added a commit that referenced this issue Jun 20, 2022
@dvirtz
feat: watch for file changes
a38e633 
closes: Old versions of files appear #38
dvirtz pushed a commit that referenced this issue Jun 20, 2022
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
2c8cfc4 
## [2.2.0](v2.1.5...v2.2.0) (2022-06-20)

### Features

* formatting JSON output ([5a61a8e](5a61a8e)), closes [#43](#43)
* watch for file changes ([a38e633](a38e633)), closes [#38](#38)

### Documentation

* update readme with grouped logging options ([2ecf274](2ecf274))

### General maintenance

* allow longer footers ([e30ba3c](e30ba3c))
* fix commitlint ([bfd5ddc](bfd5ddc))
* group logging settings ([a2ad7e1](a2ad7e1))
* release from release ([d004bd8](d004bd8))

### Build and continuous integration

* disable mac builds ([e45ed4e](e45ed4e))
* fix spelling ([67eb78d](67eb78d))
* fix vsce step ([cd6e5a6](cd6e5a6))
dvirtz pushed a commit that referenced this issue Jun 20, 2022
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
eb6e4f7 
## [2.2.0](v2.1.5...v2.2.0) (2022-06-20)

### Features

* formatting JSON output ([5a61a8e](5a61a8e)), closes [#43](#43)
* watch for file changes ([a38e633](a38e633)), closes [#38](#38)

### Documentation

* update readme with grouped logging options ([2ecf274](2ecf274))

### General maintenance

* allow longer footers ([e30ba3c](e30ba3c))
* fix commitlint ([bfd5ddc](bfd5ddc))
* group logging settings ([a2ad7e1](a2ad7e1))

### Build and continuous integration

* disable mac builds ([e45ed4e](e45ed4e))
* fix spelling ([45fdc11](45fdc11))
* fix vsce step ([cd6e5a6](cd6e5a6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvirtz dvirtz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: watch for file changes dvirtz/vscode-parquet-viewer
3 participants
@mhkeller @dvirtz @karimelghazouly