Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting JSON output #43

Closed
gregj0 opened this issue Jun 2, 2022 · 1 comment · Fixed by #50
Closed

Formatting JSON output #43

gregj0 opened this issue Jun 2, 2022 · 1 comment · Fixed by #50
Assignees
Labels

Comments

@gregj0
Copy link

gregj0 commented Jun 2, 2022

New Feature request

I am using this with a parquet file and getting one long row of JSON. Would it be possible to format the output which I believe is built into JSON.stringify() function as the third parameter is number of spaces to indent. And I think the second parameter could safely be null. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify

So could

src/paquets-backend.ts (line 22)
be changed to this to format the output?

yield `${JSON.stringify(record,null,2)}${os.EOL}`;

You could also add a boolean config setting to format output and conditionally do it (or even take the number of spaces to format and pass that)

@dvirtz dvirtz self-assigned this Jun 10, 2022
dvirtz added a commit that referenced this issue Jun 17, 2022
dvirtz added a commit that referenced this issue Jun 17, 2022
@dvirtz dvirtz linked a pull request Jun 18, 2022 that will close this issue
dvirtz added a commit that referenced this issue Jun 18, 2022
dvirtz pushed a commit that referenced this issue Jun 20, 2022
## [2.2.0](v2.1.5...v2.2.0) (2022-06-20)

### Features

* formatting JSON output ([5a61a8e](5a61a8e)), closes [#43](#43)
* watch for file changes ([a38e633](a38e633)), closes [#38](#38)

### Documentation

* update readme with grouped logging options ([2ecf274](2ecf274))

### General maintenance

* allow longer footers ([e30ba3c](e30ba3c))
* fix commitlint ([bfd5ddc](bfd5ddc))
* group logging settings ([a2ad7e1](a2ad7e1))
* release from release ([d004bd8](d004bd8))

### Build and continuous integration

* disable mac builds ([e45ed4e](e45ed4e))
* fix spelling ([67eb78d](67eb78d))
* fix vsce step ([cd6e5a6](cd6e5a6))
dvirtz pushed a commit that referenced this issue Jun 20, 2022
## [2.2.0](v2.1.5...v2.2.0) (2022-06-20)

### Features

* formatting JSON output ([5a61a8e](5a61a8e)), closes [#43](#43)
* watch for file changes ([a38e633](a38e633)), closes [#38](#38)

### Documentation

* update readme with grouped logging options ([2ecf274](2ecf274))

### General maintenance

* allow longer footers ([e30ba3c](e30ba3c))
* fix commitlint ([bfd5ddc](bfd5ddc))
* group logging settings ([a2ad7e1](a2ad7e1))

### Build and continuous integration

* disable mac builds ([e45ed4e](e45ed4e))
* fix spelling ([45fdc11](45fdc11))
* fix vsce step ([cd6e5a6](cd6e5a6))
@dvirtz
Copy link
Owner

dvirtz commented Jun 20, 2022

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants