Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep loading #81

Closed
Sangwaniya opened this issue Jul 26, 2023 · 4 comments · Fixed by #82
Closed

keep loading #81

Sangwaniya opened this issue Jul 26, 2023 · 4 comments · Fixed by #82
Assignees
@dvirtz
Labels
released

Comments

@Sangwaniya
Copy link

No link to open as JSON, file keep loading
happening with each parquet on windows in 17th July release
@dvirtz dvirtz self-assigned this Jul 26, 2023
@space7panda
Copy link

same issue on M1, tried all backends

@dvirtz
Copy link
Owner

dvirtz commented Jul 27, 2023

Thanks. I can reproduce it locally. error is

2023-07-27 16:20:57.874 [error] Activating extension dvirtz.parquet-viewer failed due to an error:
2023-07-27 16:20:57.874 [error] Error: Cannot find module 'pkg-prebuilds'
Require stack:
- .vscode\extensions\dvirtz.parquet-viewer-2.3.0\node_modules\parquet-reader\dist\index.js
- .vscode\extensions\dvirtz.parquet-viewer-2.3.0\dist\src\arrow-backend.js
- .vscode\extensions\dvirtz.parquet-viewer-2.3.0\dist\src\parquet-document.js
- .vscode\extensions\dvirtz.parquet-viewer-2.3.0\dist\src\parquet-document-provider.js
- .vscode\extensions\dvirtz.parquet-viewer-2.3.0\dist\src\parquet-editor-provider.js
- .vscode\extensions\dvirtz.parquet-viewer-2.3.0\dist\src\extension.js
- AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js
- AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-amd.js
- AppData\Local\Programs\Microsoft VS Code\resources\app\out\bootstrap-fork.js

dvirtz added a commit that referenced this issue Jul 27, 2023
@dvirtz
fix: move pkg-prebuilds should be a runtime dep
c4f05e9 
Fixes #81
This was referenced Jul 27, 2023
Merged
Closed
dvirtz added a commit that referenced this issue Jul 27, 2023
@dvirtz
fix: move pkg-prebuilds should be a runtime dep
58c15af 
Fixes #81
dvirtz pushed a commit that referenced this issue Jul 27, 2023
@semantic-release-bot
chore(release): 2.3.1 [skip ci]
d9baa1b 
## [2.3.1](v2.3.0...v2.3.1) (2023-07-27)

### Bug Fixes

* move pkg-prebuilds should be a runtime dep ([58c15af](58c15af)), closes [#81](#81)

### General maintenance

* **deps-dev:** bump word-wrap from 1.2.3 to 1.2.4 ([3c743be](3c743be))

### Build and continuous integration

* build only typescript when packaging ([4acc829](4acc829))
* disable hooks in CI ([947f61b](947f61b))
* download prebuilds before install ([43c03d9](43c03d9))
* ignore workspaces on release ([164abbe](164abbe)), closes [#76](#76)
@dvirtz
Copy link
Owner

dvirtz commented Jul 27, 2023

🎉 This issue has been resolved in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Sangwaniya
Copy link
Author

Thanks, now working AWESOME ✨✨

@akelsch akelsch mentioned this issue Jul 28, 2023
Closed
@dvirtz dvirtz mentioned this issue Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvirtz dvirtz

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix missing module dvirtz/vscode-parquet-viewer
3 participants
@dvirtz @space7panda @Sangwaniya