Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a file never ends #85

Closed
egor-ryashin opened this issue Aug 7, 2023 · 12 comments · Fixed by #86
Closed

Opening a file never ends #85

egor-ryashin opened this issue Aug 7, 2023 · 12 comments · Fixed by #86
Assignees
@dvirtz
Labels
bug Something isn't working released

Comments

@egor-ryashin
Copy link

I have a small test file that I checked with parquet-tools:

parquet-tools dump ~/arrow.parquet 
row group 0 
--------------------------------------------------------------------------------
a:  INT32 UNCOMPRESSED DO:4 FPO:30 SZ:77/77/1.00 VC:3 ENC:PLAIN,RLE,RL [more]...

    a TV=3 RL=0 DL=0 DS: 3 DE:PLAIN
    ----------------------------------------------------------------------------
    page 0:               DLE:RLE RLE:RLE VLE:RLE_DICTIONARY ST:[min:  [more]... VC:3

INT32 a 
--------------------------------------------------------------------------------
*** row group 1 of 1, values 1 to 3 *** 
value 1: R:0 D:0 V:1
value 2: R:0 D:0 V:2
value 3: R:0 D:0 V:3

I click to open in VsCode and it never ends.
@dvirtz
Copy link
Owner

dvirtz commented Aug 7, 2023

What extension version you're on?
This sounds similar to #81 which was fixed with v2.3.1

@egor-ryashin
Copy link
Author

v2.3.3

@dvirtz
Copy link
Owner

dvirtz commented Aug 7, 2023

Please look at the Extension Host output window for any errors involving parquet-tools and paste them here.

@egor-ryashin
Copy link
Author

No logs there during opening of the file.

@egor-ryashin egor-ryashin changed the title Openning a file never ends Opening a file never ends Aug 7, 2023
@dvirtz
Copy link
Owner

dvirtz commented Aug 7, 2023 via email

@egor-ryashin
Copy link
Author

example.zip

@dvirtz dvirtz self-assigned this Aug 8, 2023
@egor-ryashin
Copy link
Author

Seeing Error: invalid parquet version in the popup.

@dvirtz
Copy link
Owner

dvirtz commented Aug 10, 2023 •
edited
Loading

This version isn't supported by the parquets backend, although it still shouldn't hang opening the file.
Can you try switching to arrow backend: https://github.com/dvirtz/vscode-parquet-viewer#arrow

@egor-ryashin
Copy link
Author

egor-ryashin commented Aug 10, 2023 •
edited
Loading

I actually managed to open that file with parquet-tools backend.
But a tried a larger file and cannot open it with all 3 backends now.

@dvirtz
Copy link
Owner

dvirtz commented Aug 10, 2023

I'm glad you had success with another backend.
There's a known problem with large files: #74.
I want to implement a paged view to solve that, but it's a rather large effort.

dvirtz added a commit that referenced this issue Aug 29, 2023
@dvirtz
fix: fix infinite load on error
40c414e 
now code won't wait for user to close error message
and will display the error in the json doc

fixed #85
@dvirtz dvirtz mentioned this issue Aug 29, 2023
Merged
dvirtz added a commit that referenced this issue Aug 29, 2023
@dvirtz
fix: fix infinite load on error
9285eec 
now code won't wait for user to close error message
and will display the error in the json doc

fixed #85
dvirtz added a commit that referenced this issue Sep 8, 2023
@dvirtz
fix: fix infinite load on error
fe56c1c 
now code won't wait for user to close error message
and will display the error in the json doc

fixed #85
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 10, 2023
@dvirtz dvirtz added bug Something isn't working and removed Stale labels Sep 10, 2023
dvirtz added a commit that referenced this issue Sep 20, 2023
@dvirtz
fix: fix infinite load on error
f5967fa 
now code won't wait for user to close error message
and will display the error in the json doc

fixed #85
dvirtz pushed a commit that referenced this issue Sep 20, 2023
@semantic-release-bot
chore(release): 2.3.4 [skip ci]
274f5c6 
## [2.3.4](v2.3.3...v2.3.4) (2023-09-20)

### Bug Fixes

* fix infinite load on error ([f5967fa](f5967fa)), closes [#85](#85)

### Refactoring

* deduplicate backend unit tests ([ad14d07](ad14d07))

### General maintenance

* add python extension to devcontainer ([32857de](32857de))
* update dependencies ([6b6c7d3](6b6c7d3))

### Build and continuous integration

* update to node 18 ([407504a](407504a))
* upgrade to conan 2.x ([655dab3](655dab3))
@dvirtz
Copy link
Owner

dvirtz commented Sep 20, 2023

🎉 This issue has been resolved in version 2.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvirtz dvirtz

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue85 dvirtz/vscode-parquet-viewer
2 participants
@dvirtz @egor-ryashin