Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create simple todo list app #17

Merged
merged 40 commits into from
Mar 19, 2021
Merged

create simple todo list app #17

merged 40 commits into from
Mar 19, 2021

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Sep 11, 2020 •
edited
Loading

ref: #16

wireframes
todolist-app

widgets tree
widgets-tree

widgets tree with inspector:
widget tree

@SimonLab SimonLab self-assigned this Sep 11, 2020
@SimonLab SimonLab mentioned this pull request Sep 11, 2020
Closed
@SimonLab SimonLab mentioned this pull request Sep 17, 2020
Closed
3 tasks
@codecov
Copy link

codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@fbbf24b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master       #17   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         5           
  Lines             ?        62           
  Branches          ?         0           
==========================================
  Hits              ?        62           
  Misses            ?         0           
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbf24b...a1e27f7. Read the comment docs.

nelsonic
nelsonic reviewed Jan 27, 2021
View reviewed changes
.flutter-plugins Outdated
@@ -1,4 +1,5 @@
# This is a generated file; do not edit or check into version control.
integration_test=C:\\Users\\simon\\flutter\\flutter\\.pub-cache\\hosted\\pub.dartlang.org\\integration_test-1.0.1\\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows? 😮 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 yes I know!! my laptop has some issues so I'm using the desktop at the moment (I tried to create a dual boot with ubuntu but some problems occurs, using wsl if necessary necessary)

@nelsonic nelsonic mentioned this pull request Feb 4, 2021
Closed
@SimonLab SimonLab mentioned this pull request Feb 5, 2021
Open
2 tasks
@SimonLab
Copy link
Member Author

SimonLab commented Feb 24, 2021 •
edited
Loading

Application preview:

This PR is getting big now and I think it might be worth making it public on master to collect feedback.
The readme is not perfect but will be enhanced with future PR especially when other Flutter concepts are used on the application (e.g #26)

@SimonLab SimonLab marked this pull request as ready for review February 24, 2021 16:17
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Feb 24, 2021
@nelsonic
Copy link
Member

@SimonLab do you think you might have some time for a Zoom call to walk us through this e.g. Friday afternoon? 💭

@SimonLab
Copy link
Member Author

@nelsonic Friday afternoon sounds good for a demo 👍

nelsonic
nelsonic approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab thanks for the zoom-walkthrough of the App/UI/Code; looks great. 🎉

@nelsonic nelsonic merged commit 288d0ff into master Mar 19, 2021
@nelsonic nelsonic deleted the simple-todolist-#16 branch March 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic