Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Tidy up and Extend Learn Flutter Docs 📝 #68

Closed
8 tasks done
nelsonic opened this issue Nov 8, 2022 · 7 comments · Fixed by #69
Closed
8 tasks done

Chore: Tidy up and Extend Learn Flutter Docs 📝 #68

nelsonic opened this issue Nov 8, 2022 · 7 comments · Fixed by #69
Assignees
@nelsonic @LuchoTurtle
Labels
chore enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority-1 T4h technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Nov 8, 2022 •
edited
Loading

The contents of this repo is "OK" as a starting point but it feels like it could use some "polish" / updating.

Todo

  • Read through the repo and update to make it more beginner-friendly
  • Update any instructions & code samples as required
  • Finish any in-progress examples

Tidy Up

image
@nelsonic nelsonic added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers chore T4h priority-1 technical labels Nov 8, 2022
@nelsonic nelsonic moved this to 🔖 Ready in dwyl app kanban Nov 8, 2022
@nelsonic
Copy link
Member Author

nelsonic commented Nov 8, 2022

@LuchoTurtle if you can review this doc and update it, it would be a huge help! 🙏
I've already deleted my old ("stale") branch. ✂️
Please liberally update the grammar/style of writing to match our other projects. 📝
Anything else you think of along the way, comment! 💬

@nelsonic nelsonic removed their assignment Nov 8, 2022
@nelsonic nelsonic pinned this issue Nov 8, 2022
@LuchoTurtle LuchoTurtle moved this from 🔖 Ready to 🏗 In progress in dwyl app kanban Nov 8, 2022
@LuchoTurtle LuchoTurtle mentioned this issue Nov 8, 2022
Merged
@nelsonic nelsonic mentioned this issue Nov 8, 2022
Open
15 tasks
LuchoTurtle added a commit that referenced this issue Nov 10, 2022
@LuchoTurtle
feat: Adding testing #68
4e7ec23
LuchoTurtle added a commit that referenced this issue Nov 10, 2022
@LuchoTurtle
feat: Adding tests to the demo application. #68
68b3f07
LuchoTurtle added a commit that referenced this issue Nov 10, 2022
@LuchoTurtle
feat: Adding testing guide. #68
e026378
@nelsonic nelsonic moved this from 🏗 In progress to ⏳Awaiting Review in dwyl app kanban Nov 14, 2022
@nelsonic
Copy link
Member Author

@LuchoTurtle's PR: #69 🎉

@nelsonic nelsonic moved this from ⏳Awaiting Review to 🏗 In progress in dwyl app kanban Nov 16, 2022
@nelsonic
Copy link
Member Author

@LuchoTurtle to create a micro-PR to add GitHub Actions to this repo so that we can check everything is working. 🙏
As per: dwyl/flutter-counter-example#7 (comment)

@LuchoTurtle
Copy link
Member

@nelsonic you should find it here -> #71

@nelsonic
Copy link
Member Author

Thanks. Merged. Please confirm Working. 🤞

@LuchoTurtle
Copy link
Member

Similarly to what happened in dwyl/flutter-counter-example#6 (comment), the CI should work when working with the latest Flutter version, as it's the case with #69 . After this PR is merged, it should work 😄

@nelsonic
Copy link
Member Author

Gotcha. Thanks. 👌

nelsonic added a commit that referenced this issue Nov 18, 2022
@nelsonic
add "Mac Focussed? 🍏" section to README.md #68
e915f8c
nelsonic added a commit that referenced this issue Nov 18, 2022
@nelsonic
tidy Why section #68
3dffe61
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Nov 18, 2022
@LuchoTurtle LuchoTurtle moved this from 🏗 In progress to ⏳Awaiting Review in dwyl app kanban Nov 18, 2022
@nelsonic nelsonic moved this from ⏳Awaiting Review to 👀 In review in dwyl app kanban Nov 18, 2022
nelsonic added a commit that referenced this issue Nov 21, 2022
@nelsonic
Fix typos and formatting #68
5f91ad7
@nelsonic nelsonic moved this from 👀 In review to ⏳Awaiting Review in dwyl app kanban Dec 7, 2022
@LuchoTurtle LuchoTurtle self-assigned this Dec 13, 2022
LuchoTurtle added a commit that referenced this issue Dec 13, 2022
@LuchoTurtle
fix: Formatting and fixing typos. #68
7e1dd01
LuchoTurtle added a commit that referenced this issue Dec 13, 2022
@LuchoTurtle
feat: Adding proper CI. #68
8c453fc
LuchoTurtle added a commit that referenced this issue Dec 13, 2022
@LuchoTurtle
fix: Installing Flutter on CI using correct parameter. #68
fb031a8
@github-project-automation github-project-automation bot moved this from ⏳Awaiting Review to ✅ Done in dwyl app kanban Jan 13, 2023
@nelsonic nelsonic unpinned this issue Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

@LuchoTurtle LuchoTurtle

Labels
chore enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority-1 T4h technical
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PR] Updating README with latest version. dwyl/learn-flutter
2 participants
@nelsonic @LuchoTurtle