-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Updating README with latest version. #69
Conversation
@LuchoTurtle this PR is looking great so far! 😍 Quick Feedback: please comment as your adding things so that anyone following along can see what you're learning Also, try to reference the issue in your commit messages so that the history is easier to follow. feat: Add state management. #68 If we can be consistent with referencing issues in our commits then it makes it easier for people in the future to understand the changes when they
|
…d starting a new one. Adding first steps on README.
|
|
|
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.8, on macOS 13.0.1 22A400 darwin-arm, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.73.1)
[✓] Connected device (2 available)
[✓] HTTP Host Availability
• No issues found! |
|
||
SQLite is one of the most popular methods for storing data locally. | ||
For this demo, we will use the package | ||
[`sqflite`](https://pub.dev/packages/sqflite). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of using sqflite
in our tutorial because, as noted in: #70 we will be using drift
because it has muuuch better features, Web Support and extensive testing.
sqflite
looks quite "unkept" ... https://pub.dev/packages/sqflite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to keep the original structure, hence why I did a rundown with sqflite
.
drift
actually uses sqflite
under the hood.
Do you want me to add a section for drift
or...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. drift
uses drift_sqflite
which in turn depends on sqflite
drift_sqflite/pubspec.yaml#L13 👀
but appears to add quite a few enhancements ... ✨
We don't need to update the tutorial yet. ⏳
I just want to finish reading through this. 🙏
But left a comment as a reminder. 💭
@nelsonic I'm going to be reviewing this README for typos and formatting and will commit them to make your life easier. |
Formatted and fixed typos on README. |
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 4
Lines ? 70
Branches ? 0
========================================
Hits ? 70
Misses ? 0
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuchoTurtle awesome work as always! Let's ship this and get it into the hands of more people!
There will be enhancements especially from @SimonLab who will need to go through this on Linux
🐧
Thanks again! 🎉
closes #68
Initially thought I could tackle this in the morning but it took much longer than expected since I tried to actually understand what I was learning and writing about. Much of the information in the README was either insufficient or outdated, so I had to quite literally remake the whole README from scratch.
I'm still wanting to add a few more sections and a simple application demo to showcase most of the principles showcased in the README.
I'm going to additionally remake some of the guides that are present, as well. So this could take a little while.