Modified the distribution check to accept operating systems like Pop_os that are ubuntu/debian based and mention it differently in the /etc/os-release file

[aserper]

• What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Modified the distribution check to accept operating systems like Popthat are ubuntu/debian based and mention it differently in the /etc/os-release file

• What is the current behavior? (You can also link to an open issue here)
  installer will fail on pop_os

• What is the new behavior (if this is a feature change)? If possible add a screenshot.
  Installer will work on pop_os while still supporting the old scenario

• Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
  no

• Other information:

[m-1-k-3]

is there a copy error? Should this be something like (untested):

if ! grep -q "ID_LIKE=debian\|ID_LIKE=ubuntu" /etc/os-release

Could you provide a /etc/os-release file?

[aserper]

Here is the content of /etc/os-release on my system:
NAME="Pop!_OS"
VERSION="22.04 LTS"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 22.04 LTS"
VERSION_ID="22.04"
HOME_URL="https://pop.system76.com"
SUPPORT_URL="https://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=jammy
UBUNTU_CODENAME=jammy
LOGO=distributor-logo-pop-os

[m-1-k-3]

would this regex fit?

grep -E "ID_LIKE=(\")?(ubuntu)?( )?(debian)?"

Looks not too bad in my testset:

The first two are os-release files without debian or ubuntu entries. Then we have the popos and finally a ubuntu

[aserper]

Yes, it looks good. I was too lazy to write a regex I guess

[m-1-k-3]

Thank you for your contribution. Could you please check my comment?

[aserper]

Yes, this should work. I was too lazy to write a regex 🙃 Sent from my mobile phone - please excuse any typos

…

On Sat, Jan 28, 2023, 04:19 Michael Messner ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In installer.sh <#464 (comment)>: > @@ -145,7 +145,7 @@ if grep -q -i wsl /proc/version; then fi # distribution check -if ! grep -q "ID_LIKE=debian" /etc/os-release 2>/dev/null ; then +if ! grep -q "ID_LIKE=" /etc/os-release | grep -q "ubuntu\|debian" /etc/os-release 2>/dev/null ; then would this regex fit? grep -E "ID_LIKE=(\")?(ubuntu)?( )?(debian)?" Looks not too bad in my testset: [image: image] <https://user-images.githubusercontent.com/497520/215258067-f92c3f81-bfdd-46a1-b1b8-eb3f7f4033c7.png> — Reply to this email directly, view it on GitHub <#464 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACTUS7BKALRIS7I66MWVNS3WUTQDLANCNFSM6AAAAAAUI5WYSU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[m-1-k-3]

Could you please finalize your PR. Would be really cool to get support for PopOS to EMBA

[m-1-k-3]

Please re-open it if needed