Updated installer.sh for "ubuntu debian" /etc/os-release and new version string #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-1-k-3
requested changes
Mar 29, 2023
config/bin_version_strings.cfg
Outdated
| @@ -417,6 +417,7 @@ fsck.fat;;gplv3;"^fsck\.fat\ [0-9]+(\.[0-9]+)+?";"sed -r 's/fsck\.fat\ ([0-9]+(\ | |||
| fatlabel;;gplv3;"^fatlabel\ [0-9]+(\.[0-9]+)+?";"sed -r 's/fatlabel\ ([0-9]+(\.[0-9]+)+?).*/dosfstools:\1/'"; | |||
| mklost_plus_found;;unknown;"^mklost\+found\ [0-9]+(\.[0-9]+)+?\ \(.*\)$";"sed -r 's/mklost\+found\ ([0-9]+(\.[0-9]+)+?).*/e2fsprogs:\1/'"; | |||
| mkntfs;;gplv2;"mkntfs\ [0-9]+(\.[0-9]+)+?";"sed -r 's/mkntfs\ ([0-9]+(\.[0-9]+)+?).*/ntfsprogs:\1/'"; | |||
| mkntfs;;gplv2;"^mkntfs\ v[0-9]+(\.[0-9]+)+?";"sed -r 's/mkntfs\ ([0-9]+(\.[0-9]+)+?).*/ntfsprogs:\1/'"; | |||
There was a problem hiding this comment.
could we simplify this in the following way?
└─$ echo "mkntfs 1.2.3" | grep -E "mkntfs\ [0-9]+(\.[0-9]+)+?"
mkntfs 1.2.3
┌──(m1k3㉿emba)-[~/firmware-stuff/EMBAbite]
└─$ echo "mkntfs v1.2.3" | grep -E "mkntfs\ (v)?[0-9]+(\.[0-9]+)+?"
mkntfs v1.2.3
I think in your sed regex the "v" is missing
|
As reference. This PR should also solve #464 |
m-1-k-3
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
The installer can now be executed in ubuntu based distros that have "ubuntu debian" or debian as ID_LIKE in /etc/os-release.
New version string added
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)? If possible add a screenshot.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: