Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django requirement from ~=4.2.0 to ~=5.0 #2084

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 4, 2023

Updates the requirements on django to permit the latest version.

Commits
  • 617bcf6 [5.0.x] Bumped version for 5.0 release.
  • 94914b5 [5.0.x] Finalized release notes for Django 5.0.
  • 8e1b820 [5.0.x] Updated translations from Transifex.
  • e4d7cc3 [5.0.x] Added release date for 4.2.8.
  • cb013fc [5.0.x] Fixed #35002 -- Made UniqueConstraints with fields respect nulls_dist...
  • 6c50273 [5.0.x] Fixed #35001 -- Fixed position of related widget action icons in admi...
  • b8a476b [5.0.x] Improved wording in auth.models.User field docs.
  • 471fa92 [5.0.x] Fixed #34995 -- Improved position of related widget's add link on adm...
  • 9fe12b0 [5.0.x] Refs #34995 -- Made Selenium tests more robust for admin_views and ad...
  • 7f1dc67 [5.0.x] Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_co...
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the [T] Dependencies Used by Dependabot label Dec 4, 2023
@richardebeling
Copy link
Member

richardebeling commented Dec 4, 2023

Apart from that, I don't see anything in the changelog that seems relevant to us.

I'd also bump psycopg to 3 since that's what the django docs recommend

@richardebeling
Copy link
Member

richardebeling commented Dec 4, 2023

Very interesting, upgrading to psycopg 3 causes SQL errors, did not expect that...

psycopg.errors.InvalidColumnReference: for SELECT DISTINCT, ORDER BY expressions must appear in select list
LINE 1: ...tion_participants"."evaluation_id" = $4) ORDER BY LOWER(NULL...

@richardebeling
Copy link
Member

richardebeling commented Dec 11, 2023

I created an issue with django out the psycopg3 problem here: https://code.djangoproject.com/ticket/35028 (cc @hansegucker)

Edit: The issue discussion implies a bug in django and that it's probably easiest for us to just stick with psycopg2 for now.

@richardebeling richardebeling force-pushed the dependabot/pip/django-approx-eq-5.0 branch from f30ec6f to 2f554c4 Compare December 18, 2023 16:48
@niklasmohrin
Copy link
Member

Dependencies: Kinda unsatisfying, but as long as our tests pass, I am fine. We should maybe consider dropping django-fsm anyways.
Psycopg: Sticking to version 2 seems like the right thing to do for now

@richardebeling
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 8, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot bot and others added 4 commits January 8, 2024 17:34
Updates the requirements on [django](https://github.com/django/django) to permit the latest version.
- [Commits](django/django@4.2...5.0)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@richardebeling richardebeling force-pushed the dependabot/pip/django-approx-eq-5.0 branch from 2f554c4 to d309951 Compare January 8, 2024 16:35
@richardebeling richardebeling merged commit 5e92e91 into main Jan 8, 2024
10 checks passed
@dependabot dependabot bot deleted the dependabot/pip/django-approx-eq-5.0 branch January 8, 2024 16:59
richardebeling added a commit to richardebeling/EvaP that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[T] Dependencies Used by Dependabot
Development

Successfully merging this pull request may close these issues.

2 participants