Moving forum post blank page

[mostym]

When I try and move a forum thread the page that I get redirected to is blank. Any idea what's causing this? I am running the most current github branch. Thanks!

[Moc]

Just making some notes while trying to figure this out. May be related to userclass permissions issue:
#3525 and #3550

Clean install:

• Main Site Administrator (created during install) has no value for user_class in user table

• e107/e107_plugins/forum/forum_post.php

  Line 70 in 4becf60

  $moderatorUserIds = $forum->getModeratorUserIdsByPostId($this->post);

  returns empty array (var_dump gives array(0) { })

• e107/e107_plugins/forum/forum_class.php

  Line 417 in 4becf60

  public function getModeratorUserIdsByPostId($postId)

  query gets no results.
• forum_moderator set to 254
• e_UC_MAINADMIN is 250
• e_UC_ADMIN is 254

[Moc]

@phibel You did a lot of work on this specific area (https://github.com/e107inc/e107/commits?author=phibel). Could you look into why a Main Site Administrator is not able to move forum posts on a clean install?

[Moc]

Query gets no results because $postID = 0.

I think this:

e107/e107_plugins/forum/forum_post.php

Line 70 in 4becf60

$moderatorUserIds = $forum->getModeratorUserIdsByPostId($this->post);

needs changing to:

$moderatorUserIds = $forum->getModeratorUserIdsByPostId($this->id);

[SimSync]

Did a quick look into it and the methods to move the thread always look for a constant named MODERATOR being set. If not, moving is not allowed.
Did here some local changes do allow the Main Admin always to move threads.
This works currently. But i will also check if modifiying getModeratorUserIdsByPostId($this->id) will also do the trick.

[SimSync]

getModeratorUserIdsByPostId($this->id) doesn't work, because $this->id contains the threadid and not the postid.
Switched to getModeratorUserIdsByThreadId($this->id) to receive the moderators for the thread. This worked and included also the userid of the main admin.

[phibel]

All my test users were a member of the moderator class of the thread/forum, so I think thats why I did not run into this problem. I will try to look at it until Wednesday @Moc.

[mostym]

Are you saying that i have to create a group called MODERATOR?

[mostym]

Welp, that didn't work...

[mostym]

So from seeing this, I can't have different groups managing specific forums. That kinda defeats the point of having forum permissions, no?

[Moc]

@BigBoiJefe no, just hang on a little longer. There is a bug in the core code which causes this issue.

[SimSync]

I think my last commit should fix this issue. PR #3620 is submitted.

[phibel]

The solution from @SimSync looks good to me, I tested it in my installation.

[Moc]

Once the LANs are fixed, I'll merge in the fix.

[Moc]

@BigBoiJefe You can try and test now with the latest files. The issue should be fixed.

[mostym]

@Moc confirmed working. Thanks!