Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency Implementation (+ RPC) #305

Merged
merged 18 commits into from
Sep 29, 2022
Merged

Transparency Implementation (+ RPC) #305

merged 18 commits into from
Sep 29, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Sep 15, 2022

This PR encapsulates the following new features:

  • specs in configuration
  • Topic QoS (Reliability & Durability)
  • Data QoS (Partitions & Ownership)
  • Entity QoS (Writer Deadline to minimum)
  • keyed topics support (Support dispose instance)
  • Original source Timestamp
  • New classes (AtomicableValue (not used) & Fuzzy)
  • Refactor of some clases (Topic to struct & QoS to some structs)
  • Transparency User Documentation
  • Code Documentation
  • Transparency compose tests
  • Transparency exhaustive tests

This PR requires the Fast DDS PR eProsima/Fast-DDS#2947 to be merged

@jparisu jparisu force-pushed the tmp/rebase/transparency branch from 9527dc3 to 8b2d31b Compare September 15, 2022 14:36
@jparisu jparisu temporarily deployed to codecov September 15, 2022 14:36 Inactive
@jparisu jparisu temporarily deployed to codecov September 15, 2022 14:36 Inactive
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 53.19% // Head: 52.43% // Decreases project coverage by -0.76% ⚠️

Coverage data is based on head (22488a1) compared to base (3a215f6).
Patch coverage: 48.39% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   53.19%   52.43%   -0.77%     
==========================================
  Files         104      121      +17     
  Lines        3848     4068     +220     
  Branches     1413     1477      +64     
==========================================
+ Hits         2047     2133      +86     
- Misses        998     1108     +110     
- Partials      803      827      +24     
Impacted Files Coverage Δ
...uter_core/configuration/DDSRouterConfiguration.hpp 100.00% <ø> (ø)
...ore/configuration/DDSRouterReloadConfiguration.hpp 100.00% <ø> (ø)
...nclude/ddsrouter_core/types/dds/DataProperties.hpp 0.00% <0.00%> (ø)
...nclude/ddsrouter_core/types/topic/dds/DdsTopic.hpp 0.00% <0.00%> (ø)
ddsrouter_core/src/cpp/communication/DDSBridge.cpp 58.18% <ø> (ø)
...outer_core/src/cpp/communication/rpc/RPCBridge.cpp 0.00% <0.00%> (ø)
...core/src/cpp/communication/rpc/ServiceRegistry.cpp 0.00% <0.00%> (ø)
..._core/src/cpp/configuration/SpecsConfiguration.cpp 0.00% <0.00%> (ø)
...iguration/participant/ParticipantConfiguration.cpp 42.85% <ø> (ø)
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 45.23% <ø> (-3.66%) ⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu force-pushed the tmp/rebase/transparency branch from 8b2d31b to 15dfbbb Compare September 15, 2022 14:58
@jparisu jparisu temporarily deployed to codecov September 15, 2022 14:58 Inactive
@jparisu jparisu temporarily deployed to codecov September 15, 2022 14:58 Inactive
@jparisu jparisu force-pushed the tmp/rebase/transparency branch from 15dfbbb to 6c36d2d Compare September 16, 2022 05:53
@jparisu jparisu temporarily deployed to codecov September 16, 2022 05:53 Inactive
@jparisu jparisu temporarily deployed to codecov September 16, 2022 05:53 Inactive
@jparisu jparisu force-pushed the tmp/rebase/transparency branch from 6c36d2d to 3d513a1 Compare September 16, 2022 06:02
@jparisu jparisu temporarily deployed to codecov September 16, 2022 06:02 Inactive
@jparisu jparisu temporarily deployed to codecov September 16, 2022 06:02 Inactive
@jparisu jparisu force-pushed the tmp/rebase/transparency branch from 3d513a1 to 372eee8 Compare September 16, 2022 08:29
@jparisu jparisu temporarily deployed to codecov September 16, 2022 08:29 Inactive
@jparisu jparisu temporarily deployed to codecov September 16, 2022 08:29 Inactive
@jparisu jparisu force-pushed the tmp/rebase/transparency branch from 372eee8 to f195595 Compare September 16, 2022 08:43
@jparisu jparisu temporarily deployed to codecov September 16, 2022 08:43 Inactive
@jparisu jparisu temporarily deployed to codecov September 16, 2022 08:43 Inactive
@jparisu jparisu force-pushed the tmp/rebase/transparency branch from f195595 to e4134e8 Compare September 16, 2022 09:13
@jparisu jparisu temporarily deployed to codecov September 16, 2022 09:13 Inactive
@jparisu jparisu temporarily deployed to codecov September 16, 2022 09:13 Inactive
@jparisu jparisu changed the title TMP rebase test PR Transparency Implementation (+ RPC) Sep 16, 2022
@jparisu jparisu marked this pull request as ready for review September 16, 2022 09:43
@jparisu
Copy link
Contributor Author

jparisu commented Sep 16, 2022

Docker tests will fail till eProsima/Fast-DDS#2947 is merged in Fast-DDS.
These tests pass correctly as shown in manually executed action: https://github.com/eProsima/DDS-Router/actions/runs/3066731287

@jparisu jparisu temporarily deployed to codecov September 28, 2022 14:15 Inactive
@jparisu jparisu temporarily deployed to codecov September 28, 2022 14:15 Inactive
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov September 29, 2022 06:00 Inactive
@jparisu jparisu temporarily deployed to codecov September 29, 2022 06:00 Inactive
@jparisu jparisu temporarily deployed to codecov September 29, 2022 06:02 Inactive
@jparisu jparisu temporarily deployed to codecov September 29, 2022 06:02 Inactive
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the tmp/rebase/transparency branch from a4c47df to 72ee2ff Compare September 29, 2022 06:45
@jparisu jparisu temporarily deployed to codecov September 29, 2022 06:45 Inactive
@jparisu jparisu temporarily deployed to codecov September 29, 2022 06:45 Inactive
@jparisu jparisu temporarily deployed to codecov September 29, 2022 10:51 Inactive
@jparisu jparisu temporarily deployed to codecov September 29, 2022 10:51 Inactive
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the tmp/rebase/transparency branch from 4b73508 to 22488a1 Compare September 29, 2022 13:06
@jparisu jparisu temporarily deployed to codecov September 29, 2022 13:07 Inactive
@jparisu jparisu temporarily deployed to codecov September 29, 2022 13:07 Inactive
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants