Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Advanced Configuration Example with partitions and ownership #2947

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Implement Advanced Configuration Example with partitions and ownership #2947

merged 6 commits into from
Sep 27, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Sep 9, 2022 •
edited by rsanchez15
Loading

Signed-off-by: jparisu javierparis@eprosima.com

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This was referenced Sep 12, 2022
Merged
Merged
@EduPonz EduPonz added this to the v2.8.0 milestone Sep 21, 2022
@EduPonz EduPonz added the no-test Skip CI tests if PR marked with this label label Sep 21, 2022
@juanlofer-eprosima juanlofer-eprosima changed the title Implement Advance Configuration Example with partitions Implement Advanced Configuration Example with partitions and ownership Sep 23, 2022
jparisu and others added 5 commits September 26, 2022 07:31
@juanlofer-eprosima
Implement Advance Configuration Example with partitions
26361c4 
Signed-off-by: jparisu <javierparis@eprosima.com>
@juanlofer-eprosima
Implement ownership
55b70a3 
Signed-off-by: jparisu <javierparis@eprosima.com>
@juanlofer-eprosima
Add KeepAll History to reliable
4fffd35 
Signed-off-by: jparisu <javierparis@eprosima.com>
@juanlofer-eprosima
Apply suggestions
861e1cc 
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima
Uncrustify
075bb7c 
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
jparisu
jparisu commented Sep 26, 2022
View reviewed changes
Copy link
Contributor Author

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanlofer-eprosima
juanlofer-eprosima previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu
Copy link
Contributor Author

jparisu commented Sep 26, 2022

@richiprosima please test this

Add guid information to stdout logs
6523942 
Signed-off-by: jparisu <javierparis@eprosima.com>
@EduPonz
Copy link

EduPonz commented Sep 27, 2022

@richiprosima please test this

juanlofer-eprosima
juanlofer-eprosima approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 64797cd into master Sep 27, 2022
@EduPonz EduPonz deleted the examples/advance branch September 27, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jparisu @EduPonz @juanlofer-eprosima