Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerations are traslated to C++ signed integer enumeration [21200] #359

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 19, 2024

Description

An IDL enumeration will be translated to a C++ signed integer enumeration.

enum class MyEnum : int32_t
{
}

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Enumerations are traslated to C++ signed integer enumeration Enumerations are traslated to C++ signed integer enumeration [21200] Jun 19, 2024
Copy link

@LuciaEchevarria99 LuciaEchevarria99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware added this to the v4.0.0 milestone Jun 21, 2024
@richiware richiware merged commit 549ef80 into master Jun 21, 2024
4 checks passed
@richiware richiware deleted the feature/21199 branch June 21, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants