Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumerations are traslated to C++ signed integer enumerations [21215] #821

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Enumerations are traslated to C++ signed integer enumerations [21215] #821

merged 1 commit into from
Jun 21, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 21, 2024 •
edited by LuciaEchevarria99
Loading

Description

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@richiware
Refs #21199. Enumerations are traslated to C++ signed integer enumera…
ba87a3b 
…tion

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware mentioned this pull request Jun 21, 2024
Merged
10 tasks
@richiware
Copy link
Member Author

@richiprosima please test_3 this

@richiware richiware changed the title Enumerations are traslated to C++ signed integer enumerations Enumerations are traslated to C++ signed integer enumerations [21215] Jun 21, 2024
@richiware richiware mentioned this pull request Jun 21, 2024
Merged
8 tasks
@LuciaEchevarria99 LuciaEchevarria99 added this to the v3.0.0 milestone Jun 21, 2024
@richiware
Copy link
Member Author

@richiprosima please test_3 this

LuciaEchevarria99
LuciaEchevarria99 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit efd82d0 into master Jun 21, 2024
4 checks passed
@richiware richiware deleted the feature/21199 branch June 21, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuciaEchevarria99 LuciaEchevarria99 LuciaEchevarria99 approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @LuciaEchevarria99