Skip to content

Commit

Permalink
Use %* instead of loop in .bat scripts. (#4814) (#4818)
Browse files Browse the repository at this point in the history
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
  • Loading branch information
mergify[bot] and MiguelCompany authored May 22, 2024
1 parent 93f3625 commit d8ec40e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 22 deletions.
13 changes: 2 additions & 11 deletions tools/fastdds/fastdds.bat
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,6 @@
setlocal

set dir=%~dp0
set args=%1

:getarg
shift
if "%~1"=="" goto continue
set args=%args% %1
goto getarg

:continue

:: Check python
py --list > NUL 2>&1
Expand All @@ -25,10 +16,10 @@ if not %ERRORLEVEL%==0 (
if not "%PYTHON_VERSION%" == "" (
:: Use launcher to profit from shebang hints on fastdds.py
:: Select the correct python version to source the appropriate paths
py -%PYTHON_VERSION% "%dir%\..\tools\fastdds\fastdds.py" %args%
py -%PYTHON_VERSION% "%dir%\..\tools\fastdds\fastdds.py" %*
) else (
:: Use launcher to profit from shebang hints on fastdds.py
:: Select latest available python version
py "%dir%\..\tools\fastdds\fastdds.py" %args%
py "%dir%\..\tools\fastdds\fastdds.py" %*
)

13 changes: 2 additions & 11 deletions tools/fastdds/ros-discovery.bat
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,6 @@
setlocal

set dir=%~dp0
set args=%1

:getarg
shift
if "%~1"=="" goto continue
set args=%args% %1
goto getarg

:continue

:: Check python
py --list > NUL 2>&1
Expand All @@ -25,10 +16,10 @@ if not %ERRORLEVEL%==0 (
if not "%PYTHON_VERSION%" == "" (
:: Use launcher to profit from shebang hints on fastdds.py
:: Select the correct python version to source the appropriate paths
py -%PYTHON_VERSION% "%dir%\..\tools\fastdds\fastdds.py" discovery %args%
py -%PYTHON_VERSION% "%dir%\..\tools\fastdds\fastdds.py" discovery %*
) else (
:: Use launcher to profit from shebang hints on fastdds.py
:: Select latest available python version
py "%dir%\..\tools\fastdds\fastdds.py" discovery %args%
py "%dir%\..\tools\fastdds\fastdds.py" discovery %*
)

0 comments on commit d8ec40e

Please sign in to comment.