Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21037] Use %* instead of loop in .bat scripts #4814

Merged
merged 1 commit into from
May 21, 2024
Merged

[21037] Use %* instead of loop in .bat scripts #4814

merged 1 commit into from
May 21, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented May 20, 2024 •
edited by EduPonz
Loading

Description

A small improvement that changes the loop populating args variable into using the built-in %*.
See docs here

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #21037. Use %* instead of loop in .bat scripts.
27d2cc5 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v3.0.0 milestone May 20, 2024
@EduPonz EduPonz self-requested a review May 21, 2024 05:41
@github-actions github-actions bot added the ci-pending PR which CI is running label May 21, 2024
EduPonz
EduPonz approved these changes May 21, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green Windows CI

@EduPonz
Copy link

EduPonz commented May 21, 2024

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

@EduPonz EduPonz merged commit 2552fa9 into master May 21, 2024
5 of 12 checks passed
@EduPonz EduPonz deleted the hotfix/21037 branch May 21, 2024 09:04
mergify bot pushed a commit that referenced this pull request May 21, 2024
@MiguelCompany @mergify
Use %* instead of loop in .bat scripts. (#4814)
266de30 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)
@mergify mergify bot mentioned this pull request May 21, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request May 21, 2024
@MiguelCompany @mergify
Use %* instead of loop in .bat scripts. (#4814)
ed6d826 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)

# Conflicts:
#	tools/fastdds/fastdds.bat
#	tools/fastdds/ros-discovery.bat
@mergify mergify bot mentioned this pull request May 21, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request May 21, 2024
@MiguelCompany @mergify
Use %* instead of loop in .bat scripts. (#4814)
ea5d9c7 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)
@mergify mergify bot mentioned this pull request May 21, 2024
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request May 21, 2024
@MiguelCompany @mergify
Use %* instead of loop in .bat scripts. (#4814)
03fe026 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)
@mergify mergify bot mentioned this pull request May 21, 2024
Merged
9 tasks
EduPonz pushed a commit that referenced this pull request May 22, 2024
@mergify @MiguelCompany
Use %* instead of loop in .bat scripts. (#4814) (#4818)
d8ec40e 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
JesusPoderoso pushed a commit that referenced this pull request May 24, 2024
@MiguelCompany @JesusPoderoso
Use %* instead of loop in .bat scripts. (#4814)
08691c6 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)
MiguelCompany added a commit that referenced this pull request May 25, 2024
@mergify @MiguelCompany
Use %* instead of loop in .bat scripts. (#4814) (#4820)
c537064 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 27, 2024
@mergify @MiguelCompany
Use %* instead of loop in .bat scripts. (#4814) (#4819)
829348f 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
EduPonz pushed a commit that referenced this pull request May 29, 2024
@mergify @MiguelCompany
Use %* instead of loop in .bat scripts. (#4814) (#4821)
b6c3869 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz