Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21037] Use %* instead of loop in .bat scripts (backport #4814) #4821

Merged
merged 1 commit into from
May 29, 2024
Merged

[21037] Use %* instead of loop in .bat scripts (backport #4814) #4821

merged 1 commit into from
May 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 21, 2024

Description

A small improvement that changes the loop populating args variable into using the built-in %*.
See docs here

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.
This is an automatic backport of pull request #4814 done by [Mergify](https://mergify.com).

@MiguelCompany @mergify
Use %* instead of loop in .bat scripts. (#4814)
03fe026 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 2552fa9)
@mergify mergify bot mentioned this pull request May 21, 2024
Merged
9 tasks
@EduPonz EduPonz added this to the v2.6.9 milestone May 21, 2024
@Mario-DL Mario-DL self-requested a review May 28, 2024 07:59
@github-actions github-actions bot added the ci-pending PR which CI is running label May 28, 2024
Mario-DL
Mario-DL approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM failed tests unrelated with the changes

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 28, 2024
@EduPonz EduPonz merged commit b6c3869 into 2.6.x May 29, 2024
6 of 12 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.6.x/pr-4814 branch May 29, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.6.9
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @EduPonz @MiguelCompany