-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not enough memory to cipher payload [13364] #2379
Labels
bug
Issue to report a bug
Comments
MiguelCompany
changed the title
Not enough memory to cipher payload.
Not enough memory to cipher payload [13364]
Jan 3, 2022
MiguelCompany
added a commit
that referenced
this issue
Jan 5, 2022
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
JLBuenoLopez
pushed a commit
that referenced
this issue
Feb 10, 2022
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this issue
Feb 22, 2022
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
pushed a commit
that referenced
this issue
Nov 27, 2023
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this issue
Dec 13, 2023
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
EduPonz
pushed a commit
that referenced
this issue
Dec 16, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
mergify bot
pushed a commit
that referenced
this issue
Dec 16, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25dee05)
mergify bot
pushed a commit
that referenced
this issue
Dec 16, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25dee05)
mergify bot
pushed a commit
that referenced
this issue
Dec 16, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25dee05)
EduPonz
pushed a commit
that referenced
this issue
Dec 18, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25dee05) Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>
EduPonz
pushed a commit
that referenced
this issue
Dec 18, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25dee05) Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>
EduPonz
pushed a commit
that referenced
this issue
Dec 18, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 25dee05) Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com>
EduPonz
pushed a commit
that referenced
this issue
Dec 20, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this issue
Dec 21, 2023
* Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
added a commit
that referenced
this issue
Dec 22, 2023
* Fix memory problem when ciphering payload (#2485) * Refs 13364. Regression test. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. fix build when TLS_FOUND Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> * Refs 13364. Test with different lengths. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Apply review suggestions. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs 13364. Fix #2379. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Include what you use in DDSBlackboxTestsSecurity.cpp Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #13364. Fix warning. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> * Fix build with TLS, but not security (#4156) Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> Co-authored-by: José Luis Bueno López <69244257+JLBuenoLopez-eProsima@users.noreply.github.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an error when try to send a big message (near 64 Kb boundary). It seems that encryption overhead is not considered when packing submessages inside
RTPSMessageGroup
. Such error occurs when the encryption plugin tries to encode the message, but it is too late. All of this can lead to message retransmission or even inability to send the message at all.Expected Behavior
It should be possible send messages of any size. If the submessage does not fit into the buffer then it should be split into smaller chunks.
Current Behavior
There are the following error logs:
Steps to Reproduce
System information
Additional context
There is some attempt to limit a message size in
DataMsg::addSubmessageData()
:But this code does not consider an encryption overhead and the fact that buffer size can less than a hardcoded value. Right now the buffer size is less than 65535, because of memory alignment.
Also in the function
RTPSMessageGroup::insert_submessage()
:big_message_test.zip
The text was updated successfully, but these errors were encountered: