Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several issues on security code [13374] #2386

Closed
wants to merge 15 commits into from
Closed

Fix several issues on security code [13374] #2386

wants to merge 15 commits into from

Conversation

MiguelCompany
Copy link
Member

This should fix #2332, fix #2320, fix #2362, and fix #2379.

Changes are independent, so we can split this PR into several if necessary

@MiguelCompany
Refs 13365. Fix #2332.
2f03eb0 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12974. Uncrustify.
d103882 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12974. Regression tests.
d4ceea4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 12974. Fix #2320.
987bf7f 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.5.1 milestone Jan 4, 2022
@MiguelCompany MiguelCompany marked this pull request as draft January 5, 2022 07:40
@MiguelCompany
Refs 13295. Regression test.
56fa7bf 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13295. Make new test build with old API.
d8ef90a 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13295. Fix #2362.
c6aba1a 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13295. Uncrustify unit tests.
22ebb3b 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13295. Fixed unit tests.
e4cbb2e 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13295. More uncrustify.
e75fc41 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13364. Regression test.
d5f531e 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13364. Test with different lengths.
e70b411 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13364. Fix #2379.
4c1d7f4 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany marked this pull request as ready for review January 5, 2022 11:19
JLBuenoLopez
JLBuenoLopez suggested changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it seems that test communication.SimpleCommunicationSecureMsgCryptoBestEffort has been broken in all platforms. And in Windows several blackbox security tests have also failed.

src/cpp/security/authentication/PKIDH.cpp Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsSecurity.cpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsSecurity.cpp Outdated Show resolved Hide resolved
test/blackbox/common/DDSBlackboxTestsSecurity.cpp Outdated Show resolved Hide resolved
@MiguelCompany
Refs 13364.Apply review suggestions.
e5fb5b7 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Refs 13365. Free DH when it cannot be assigned.
c23d31d 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@JLBuenoLopez
Copy link
Contributor

This PR has been split into #2481, #2482, #2483 and #2485, so this one can be closed.

@MiguelCompany MiguelCompany deleted the bugfix/security-fixes branch December 27, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.1
2 participants
@MiguelCompany @JLBuenoLopez