Return const ref to reduce copies/allocations #332
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when running memory audits on the
rmw
implementations: there is a place where a copy is being used when aconst ref
should suffice, causing some additional allocations and frees:In https://github.com/eProsima/Fast-RTPS/blob/master/src/cpp/publisher/PublisherImpl.cpp#L128, when the
RTPSParticipantAttributes
are retrieved, a copy is returned, rather than a reference or const reference.As far as I could tell, the copy variant of the method wasn't being used anywhere, so switching to the
const ref
version shouldn't cause issues. If it is being used, then having multiple variations should be suitable.