[20311] Add missing TypeLookup listeners #4335

irenebm · 2024-01-30T15:34:58Z

Description

This pull request addresses an issue where Fast DDS fails to discover certain types when receiving a significant number of dynamic types (approximately 25).

This PR implements the onWriterChangeReceivedByAll listener for both TypeLookupReplyListener and TypeLookupRequestListener. This enables the deletion of changes received by all readers matched with the writer from the history. It prevents the CacheChange from becoming saturated, thus enabling the system to accommodate further changes effectively.

@Mergifyio backport 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A; Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

include/fastdds/dds/builtin/typelookup/TypeLookupReplyListener.hpp

src/cpp/fastdds/builtin/typelookup/TypeLookupManager.cpp

JesusPoderoso · 2024-02-21T15:40:26Z

@richiprosima please test this

src/cpp/fastdds/builtin/typelookup/TypeLookupManager.cpp

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz · 2024-02-22T11:56:20Z

@richiprosima please test this

EduPonz · 2024-02-22T12:00:27Z

@Mergifyio backport 2.12.x 2.10.x 2.6.x

mergify · 2024-02-22T12:00:31Z

backport 2.12.x 2.10.x 2.6.x

✅ Backports have been created

#4436 [20311] Add missing TypeLookup listeners (backport #4335) has been created for branch 2.12.x
#4437 [20311] Add missing TypeLookup listeners (backport #4335) has been created for branch 2.10.x but encountered conflicts
#4438 [20311] Add missing TypeLookup listeners (backport #4335) has been created for branch 2.6.x but encountered conflicts

* Add listener classes to handle cache change acknowledgments Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Uncrustify Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Fix memory leaks in TypeLookupManager.cpp * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Refs #20311: Further refactor TypeLookupManager::create_endpoints Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 6cb5ebb) Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Add listener classes to handle cache change acknowledgments Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Uncrustify Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Fix memory leaks in TypeLookupManager.cpp * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Refs #20311: Further refactor TypeLookupManager::create_endpoints Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 6cb5ebb)

* Add listener classes to handle cache change acknowledgments Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Uncrustify Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Fix memory leaks in TypeLookupManager.cpp * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Refs #20311: Further refactor TypeLookupManager::create_endpoints Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 6cb5ebb) Co-authored-by: Irene Bandera Moreno <irenebandera@eprosima.com>

* Add listener classes to handle cache change acknowledgments * Uncrustify * Fix memory leaks in TypeLookupManager.cpp * Apply changes * Apply changes * Refs #20311: Further refactor TypeLookupManager::create_endpoints --------- (cherry picked from commit 6cb5ebb) Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Irene Bandera Moreno <irenebandera@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>

* Add listener classes to handle cache change acknowledgments Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Uncrustify Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Fix memory leaks in TypeLookupManager.cpp * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Refs #20311: Further refactor TypeLookupManager::create_endpoints Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>

* Add listener classes to handle cache change acknowledgments * Uncrustify * Fix memory leaks in TypeLookupManager.cpp * Apply changes * Apply changes * Refs #20311: Further refactor TypeLookupManager::create_endpoints --------- (cherry picked from commit 6cb5ebb) Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Irene Bandera Moreno <irenebandera@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>

* Add listener classes to handle cache change acknowledgments Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Uncrustify Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Fix memory leaks in TypeLookupManager.cpp * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Refs #20311: Further refactor TypeLookupManager::create_endpoints Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>

* Add listener classes to handle cache change acknowledgments * Uncrustify * Fix memory leaks in TypeLookupManager.cpp * Apply changes * Apply changes * Refs #20311: Further refactor TypeLookupManager::create_endpoints --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Irene Bandera Moreno <irenebandera@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>

irenebm force-pushed the bugfix/typelookup_listeners branch from c1cc01a to 110106f Compare January 31, 2024 08:25

Mario-DL added this to the v2.13.3 milestone Feb 14, 2024

irenebm changed the title ~~Add listener classes to handle cache change acknowledgments~~ TypeLookup listener classes to handle cache change acknowledgments Feb 21, 2024

irenebm marked this pull request as ready for review February 21, 2024 08:03

EduPonz changed the title ~~TypeLookup listener classes to handle cache change acknowledgments~~ [20311] TypeLookup listener classes to handle cache change acknowledgments Feb 21, 2024

EduPonz suggested changes Feb 21, 2024

View reviewed changes

include/fastdds/dds/builtin/typelookup/TypeLookupReplyListener.hpp Outdated Show resolved Hide resolved

src/cpp/fastdds/builtin/typelookup/TypeLookupManager.cpp Outdated Show resolved Hide resolved

src/cpp/fastdds/builtin/typelookup/TypeLookupManager.cpp Outdated Show resolved Hide resolved

irenebm changed the title ~~[20311] TypeLookup listener classes to handle cache change acknowledgments~~ [20311] Add missing TypeLookup listeners Feb 21, 2024

irenebm force-pushed the bugfix/typelookup_listeners branch from 110106f to 524d2a0 Compare February 21, 2024 10:26

EduPonz suggested changes Feb 21, 2024

View reviewed changes

src/cpp/fastdds/builtin/typelookup/TypeLookupManager.cpp Show resolved Hide resolved

irenebm and others added 6 commits February 22, 2024 12:09

Add listener classes to handle cache change acknowledgments

decbee7

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Uncrustify

484b608

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Fix memory leaks in TypeLookupManager.cpp

e0b9c23

Apply changes

cf01f87

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Apply changes

a9ac2a4

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

Refs #20311: Further refactor TypeLookupManager::create_endpoints

dd7575a

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz force-pushed the bugfix/typelookup_listeners branch from 3291c6b to dd7575a Compare February 22, 2024 11:10

EduPonz added the ci-pending PR which CI is running label Feb 22, 2024

EduPonz approved these changes Feb 22, 2024

View reviewed changes

EduPonz merged commit 6cb5ebb into master Feb 22, 2024
12 of 15 checks passed

EduPonz deleted the bugfix/typelookup_listeners branch February 22, 2024 17:32

mergify bot mentioned this pull request Feb 22, 2024

[20311] Add missing TypeLookup listeners (backport #4335) #4436

Merged

This was referenced Feb 22, 2024

[20311] Add missing TypeLookup listeners (backport #4335) #4437

Merged

[20311] Add missing TypeLookup listeners (backport #4335) #4438

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20311] Add missing TypeLookup listeners #4335

[20311] Add missing TypeLookup listeners #4335

irenebm commented Jan 30, 2024 •

edited by EduPonz

Loading

JesusPoderoso commented Feb 21, 2024

EduPonz commented Feb 22, 2024

EduPonz commented Feb 22, 2024

mergify bot commented Feb 22, 2024 •

edited

Loading

[20311] Add missing TypeLookup listeners #4335

[20311] Add missing TypeLookup listeners #4335

Conversation

irenebm commented Jan 30, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

JesusPoderoso commented Feb 21, 2024

EduPonz commented Feb 22, 2024

EduPonz commented Feb 22, 2024

mergify bot commented Feb 22, 2024 • edited Loading

✅ Backports have been created

irenebm commented Jan 30, 2024 •

edited by EduPonz

Loading

mergify bot commented Feb 22, 2024 •

edited

Loading