[20311] Add missing TypeLookup listeners (backport #4335) #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
11 tasks
|
@irenebm would you mind taking a look at the conflicts ? |
irenebm
force-pushed
the
mergify/bp/2.6.x/pr-4335
branch
from
0cbb4f0
to
19e12c9
Compare
EduPonz
added
ci-pending
|
@Mergifyio rebase 2.6.x |
✅ Branch has been successfully rebased |
Mario-DL
force-pushed
the
mergify/bp/2.6.x/pr-4335
branch
from
19e12c9
to
02a091b
Compare
|
@richiprosima please test this |
|
@Mergifyio rebase 2.6.x |
* Add listener classes to handle cache change acknowledgments Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Uncrustify Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Fix memory leaks in TypeLookupManager.cpp * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Apply changes Signed-off-by: Irene Bandera <irenebandera@eprosima.com> * Refs #20311: Further refactor TypeLookupManager::create_endpoints Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: Irene Bandera <irenebandera@eprosima.com> Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: EduPonz <eduardoponz@eprosima.com>
✅ Branch has been successfully rebased |
Mario-DL
force-pushed
the
mergify/bp/2.6.x/pr-4335
branch
from
02a091b
to
9780e27
Compare
|
@richiprosima please test this |
Mario-DL
approved these changes
Apr 4, 2024
Mario-DL
added
ready-to-merge
|
Failed tests are unrelated to this PR, ready to merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4335 done by Mergify.
Cherry-pick of 6cb5ebb has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com