[20439] Expose Authentication Handshake Properties #4435

Mario-DL · 2024-02-22T17:32:50Z

Description

This PR adds the documentation for configuring the Authentication Handshake behavior through the following properties:

max_handshake_requests
initial_handshake_resend_period
handshake_resend_period_gain

It also includes a simple PropertyParser for parsing properties as int and double.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
New feature has been documented/Current behavior is correctly described in the documentation.
<Related documentation PR: [20439] Authentication Handshake Properties documentation Fast-DDS-docs#681
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Mario-DL · 2024-02-23T12:59:32Z

@richiprosima please test linux

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

…Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL · 2024-02-26T06:43:59Z

@richiprosima please test linux

Mario-DL · 2024-02-26T06:46:40Z

(Rebased on top of 31a83ca for avoiding 2.14 TODO compilation warning)

Mario-DL · 2024-02-26T08:22:27Z

@richiprosima please test discovery_server

src/cpp/rtps/security/SecurityManager.h

src/cpp/rtps/security/SecurityManager.cpp

include/fastdds/rtps/common/Property.h

test/blackbox/api/fastrtps_deprecated/PubSubWriter.hpp

test/blackbox/common/BlackboxTestsSecurity.cpp

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL · 2024-02-26T16:55:26Z

@richiprosima please test linux test discovery_server

… range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL · 2024-02-27T18:13:17Z

@richiprosima please test linux test discovery_server

test/blackbox/common/BlackboxTestsSecurity.cpp

EduPonz · 2024-02-29T11:36:40Z

@richiprosima please test discovery-server test windows

EduPonz · 2024-03-01T06:52:25Z

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

mergify · 2024-03-01T06:52:27Z

backport 2.13.x 2.12.x 2.10.x 2.6.x

✅ Backports have been created

#4485 [20439] Expose Authentication Handshake Properties (backport #4435) has been created for branch 2.13.x
#4486 [20439] Expose Authentication Handshake Properties (backport #4435) has been created for branch 2.12.x but encountered conflicts
#4487 [20439] Expose Authentication Handshake Properties (backport #4435) has been created for branch 2.10.x but encountered conflicts
#4488 [20439] Expose Authentication Handshake Properties (backport #4435) has been created for branch 2.6.x but encountered conflicts

* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84)

* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84) # Conflicts: # src/cpp/rtps/security/SecurityManager.h # versions.md

* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Expose Authentication Handshake Properties (#4435) * Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20551: Fix test. Do not depend on the XML substituting feature Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84)

* Expose Authentication Handshake Properties (#4435) * Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84) * Solve conflicts Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> --------- Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com> Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com> Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>

* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84) Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>

EduPonz added this to the v2.14.0 milestone Feb 22, 2024

Mario-DL force-pushed the feature/20439 branch from 2cf6e9c to 332df27 Compare February 23, 2024 07:48

Mario-DL added 7 commits February 26, 2024 07:40

Refs #20439: Blackbox tests

31d2bd3

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20439: Add new get_property() api method in PropertyPolicy

312a9a7

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20439: Add new PropertyParser module in Property.h

6c66e60

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20439: Integrate AuthenticationHandshakeProperties in Security …

decab8d

…Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20439: Linter

17d506a

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20439: Fix elapsed time test comparison

f856919

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Refs #20439: versions.md

d07bd96

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL force-pushed the feature/20439 branch from 332df27 to d07bd96 Compare February 26, 2024 06:43

elianalf suggested changes Feb 26, 2024

View reviewed changes

Refs #20439: Review suggestions

26edae5

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

Mario-DL force-pushed the feature/20439 branch from fa8ef4b to 26edae5 Compare February 26, 2024 16:55

Refs #20439: Make ints size explicit. Leave it as 32 to cover all the…

05299b8

… range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

elianalf approved these changes Feb 28, 2024

View reviewed changes

test/blackbox/common/BlackboxTestsSecurity.cpp Show resolved Hide resolved

EduPonz added the ci-pending PR which CI is running label Feb 29, 2024

EduPonz merged commit da58d84 into master Mar 1, 2024
13 of 16 checks passed

EduPonz deleted the feature/20439 branch March 1, 2024 06:52

mergify bot mentioned this pull request Mar 1, 2024

[20439] Expose Authentication Handshake Properties (backport #4435) #4485

Merged

mergify bot mentioned this pull request Mar 1, 2024

[20439] Expose Authentication Handshake Properties (backport #4435) #4486

Merged

mergify bot mentioned this pull request Mar 1, 2024

[20439] Expose Authentication Handshake Properties (backport #4435) #4487

Merged

mergify bot mentioned this pull request Mar 1, 2024

[20439] Expose Authentication Handshake Properties (backport #4435) #4488

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20439] Expose Authentication Handshake Properties #4435

[20439] Expose Authentication Handshake Properties #4435

Mario-DL commented Feb 22, 2024 •

edited by EduPonz

Loading

Mario-DL commented Feb 23, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 27, 2024

EduPonz commented Feb 29, 2024

EduPonz commented Mar 1, 2024

mergify bot commented Mar 1, 2024 •

edited

Loading

[20439] Expose Authentication Handshake Properties #4435

[20439] Expose Authentication Handshake Properties #4435

Conversation

Mario-DL commented Feb 22, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

Mario-DL commented Feb 23, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 26, 2024

Mario-DL commented Feb 27, 2024

EduPonz commented Feb 29, 2024

EduPonz commented Mar 1, 2024

mergify bot commented Mar 1, 2024 • edited Loading

✅ Backports have been created

Mario-DL commented Feb 22, 2024 •

edited by EduPonz

Loading

mergify bot commented Mar 1, 2024 •

edited

Loading