-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20439] Expose Authentication Handshake Properties (backport #4435) #4486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of da58d84 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
14 tasks
elianalf
added
ci-pending
PR which CI is running
and removed
conflicts
Backport PR wich git cherry pick failed
labels
Mar 12, 2024
* Refs #20439: Blackbox tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new get_property() api method in PropertyPolicy Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Add new PropertyParser module in Property.h Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Integrate AuthenticationHandshakeProperties in Security Manager Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Fix elapsed time test comparison Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: versions.md Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Review suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20439: Make ints size explicit. Leave it as 32 to cover all the range of stoi() Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit da58d84)
elianalf
force-pushed
the
mergify/bp/2.12.x/pr-4435
branch
from
March 12, 2024 07:09
b6387c3
to
c192744
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@richiprosima please test this |
@richiprosima please test mac |
elianalf
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Mar 13, 2024
elianalf
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4435 done by Mergify.
Cherry-pick of da58d84 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com