Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21158] CI - Avoid CCache in workflows and nightlys #4971

Merged
merged 2 commits into from
Jun 20, 2024
Merged

[21158] CI - Avoid CCache in workflows and nightlys #4971

merged 2 commits into from
Jun 20, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jun 20, 2024 •
edited by EduPonz
Loading

Description

This PR performs the following improvements in this project CI:

  • Avoid CCache in all workflows, keeping it configurable in most of them for debug purposes
  • Avoid CCache also in nightlys

Important: Backports must remove nightly workflows

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso
Refs #21158: Remove CCache in Ubuntu nightly workflows
a1a70f8 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21158: Avoid CCache in remain workflows
2602726 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jun 20, 2024
@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Jun 20, 2024
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz June 20, 2024 06:21
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz June 20, 2024 07:44
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 20, 2024
Closed
7 tasks
@JesusPoderoso JesusPoderoso changed the title [21158] CI - Avoid CCache in workflows and nightlys, and make skipped jobs pass with green CI [21158] CI - Avoid CCache in workflows and nightlys Jun 20, 2024
@JesusPoderoso JesusPoderoso added no-test Skip CI tests if PR marked with this label and removed skip-ci Automatically pass CI labels Jun 20, 2024
@JesusPoderoso JesusPoderoso requested review from EduPonz and removed request for EduPonz June 20, 2024 08:31
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso
Copy link
Contributor Author

To ensure that the Sanitizer job does not use CCache (it has been skipped due to the no-test flag), a manual run has been triggered with ctest-args -N to avoid running tests.

@EduPonz EduPonz merged commit 7f6f423 into master Jun 20, 2024
20 of 134 checks passed
@EduPonz EduPonz deleted the hotfix/ci/avoid_ccache branch June 20, 2024 10:19
@EduPonz
Copy link

EduPonz commented Jun 20, 2024

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 20, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso @mergify
CI - Avoid CCache in workflows and nightlies (#4971)
bca9f68 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

# Conflicts:
#	.github/workflows/mac-ci.yml
#	.github/workflows/nightly-mac-ci.yml
#	.github/workflows/nightly-ubuntu-ci.yml
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso @mergify
CI - Avoid CCache in workflows and nightlies (#4971)
f2dfa1d 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

# Conflicts:
#	.github/workflows/mac-ci.yml
#	.github/workflows/nightly-mac-ci.yml
#	.github/workflows/nightly-ubuntu-ci.yml
This was referenced Jun 20, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso @mergify
CI - Avoid CCache in workflows and nightlies (#4971)
a2068d2 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

# Conflicts:
#	.github/workflows/mac-ci.yml
#	.github/workflows/nightly-mac-ci.yml
#	.github/workflows/nightly-ubuntu-ci.yml
@mergify mergify bot mentioned this pull request Jun 20, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso @mergify
CI - Avoid CCache in workflows and nightlies (#4971)
4939cde 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

# Conflicts:
#	.github/workflows/mac-ci.yml
#	.github/workflows/nightly-mac-ci.yml
#	.github/workflows/nightly-ubuntu-ci.yml
#	.github/workflows/reusable-mac-ci.yml
#	.github/workflows/reusable-sanitizers-ci.yml
@mergify mergify bot mentioned this pull request Jun 20, 2024
Merged
7 tasks
JesusPoderoso added a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971)
39aafd5 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)
JesusPoderoso added a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971)
37ccf78 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)
JesusPoderoso added a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971)
54db143 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)
JesusPoderoso added a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971)
f6e6db1 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)
JesusPoderoso added a commit that referenced this pull request Jun 20, 2024
@JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971)
f5208ae 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)
EduPonz pushed a commit that referenced this pull request Jun 20, 2024
@mergify @JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971) (#4974)
4e89ae3 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Jun 20, 2024
@mergify @JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971) (#4973)
af83586 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Jun 20, 2024
@mergify @JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971) (#4975)
9191db4 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Jun 20, 2024
@mergify @JesusPoderoso
CI - Avoid CCache in workflows and nightlies (#4971) (#4976)
5def16c 
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)

Co-authored-by: Jesús Poderoso <120394830+JesusPoderoso@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @EduPonz