Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21158] CI - Avoid CCache in workflows and nightlys (backport #4971) #4975

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 20, 2024

Description

This PR performs the following improvements in this project CI:

  • Avoid CCache in all workflows, keeping it configurable in most of them for debug purposes
  • Avoid CCache also in nightlys

Important: Backports must remove nightly workflows

@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • N/A Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4971 done by [Mergify](https://mergify.com).

Copy link
Contributor Author

mergify bot commented Jun 20, 2024

Cherry-pick of 7f6f423 has failed:

On branch mergify/bp/2.10.x/pr-4971
Your branch is up to date with 'origin/2.10.x'.

You are currently cherry-picking commit 7f6f42357.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/reusable-mac-ci.yml
	modified:   .github/workflows/reusable-sanitizers-ci.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   .github/workflows/mac-ci.yml
	deleted by us:   .github/workflows/nightly-mac-ci.yml
	deleted by us:   .github/workflows/nightly-ubuntu-ci.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Jun 20, 2024
* Refs #21158: Remove CCache in Ubuntu nightly workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #21158: Avoid CCache in remain workflows

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
(cherry picked from commit 7f6f423)
@JesusPoderoso JesusPoderoso added this to the v2.10.5 milestone Jun 20, 2024
@JesusPoderoso JesusPoderoso added no-test Skip CI tests if PR marked with this label and removed conflicts Backport PR wich git cherry pick failed labels Jun 20, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jun 20, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso
Copy link
Contributor

To ensure that the Sanitizer job does not use CCache (it has been skipped due to the no-test flag), a manual run has been triggered with ctest-args -N to avoid running tests.

@JesusPoderoso
Copy link
Contributor

All jobs have skipped the setup CCache step.
Ready to merge!

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running labels Jun 20, 2024
@EduPonz EduPonz merged commit 9191db4 into 2.10.x Jun 20, 2024
18 of 19 checks passed
@EduPonz EduPonz deleted the mergify/bp/2.10.x/pr-4971 branch June 20, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants