-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented support for filters and removable routes in WebServer #2225
feat: Implemented support for filters and removable routes in WebServer #2225
Conversation
You need to run |
Apparently, a lot of files weren't conforming to suggested format. I ran |
CI style check failed. Can this be due to different |
f1a2b07
to
df3f635
Compare
Fixed example & formatting. PS: I formatted WebServer folder only instead of whole library. |
Weird about the astyle version differences, thx for fixing it. CI is using whatever the GH runner has installed which seems to match my own version for output (but not revision number). For the callback build error, I haven't dug into it yet but in this core I split out the HTTPServer from the Webserver. This lets us support HTTPS and HTTP servers with no extra code. Separation of duties, the template (WebServer/WebServerSecure) handles incoming connections and passes it on to the HTTP parsing engine. |
b8aed91
to
7c581e3
Compare
Fixed everything and tested locally. This should pass all CI tests. Also, ESP32 PRs are merged therefore this PR is ready for merger too. |
This PR implements filters and removable routes in RP2040 arduino core, making it API compatible with recent changes to ESP32 & ESP8266 WebServer API.
Note
Please merge when all ESP32 repo pull requests mentioned below are merged.
Reference (Recent additions to ESP32 WebServer API):
Reference (Recent addition to ESP8266 WebServer API):
Noteable Changes:
setFilter
)removeRoute
,removeHandler
,_removeRequestHandler
)