Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for removing routes in WebServer library #9832

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

ayushsharma82
Copy link
Contributor

@ayushsharma82 ayushsharma82 commented Jun 11, 2024

Description of Change

Added support for removing routes in WebServer library. This PR implements removeRoute and removeHandler methods to remove any specific route which was added earlier using on function of WebServer library.

Tests scenarios

I have tested this PR on arduino-esp32 core v2.0.17 with ESP32 (Wemos D1 Mini ESP32 Board)

Update (12-06-2024): Tested with arduino-esp32 core v3.0.1 too. Works well and good.

Related links

--

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello ayushsharma82, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6b4d053

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Test Results

 56 files   56 suites   5m 11s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit 6b4d053.

♻️ This comment has been updated with latest results.

@VojtechBartoska VojtechBartoska added this to the 3.0.2 milestone Jun 12, 2024
@VojtechBartoska VojtechBartoska added the Area: Libraries Issue is related to Library support. label Jun 12, 2024
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Jun 13, 2024
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WebServer/examples/AdvancedWebServer----------
WebServer/examples/FSBrowser----------
WebServer/examples/HelloServer----------
WebServer/examples/HttpAdvancedAuth----------
WebServer/examples/HttpAuthCallback----------
WebServer/examples/HttpAuthCallbackInline----------
WebServer/examples/HttpBasicAuth----------
WebServer/examples/HttpBasicAuthSHA1----------
WebServer/examples/HttpBasicAuthSHA1orBearerToken----------
WebServer/examples/MultiHomedServers----------
WebServer/examples/PathArgServer----------
WebServer/examples/SDWebServer----------
WebServer/examples/SimpleAuthentification----------
WebServer/examples/UploadHugeFile----------
WebServer/examples/WebServer----------
WebServer/examples/WebUpdate----------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants