use updated config.guess in GCC easyblock #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoors
reviewed
Apr 17, 2020
easybuild/easyblocks/g/gcc.py
Outdated
Comment on lines
388
to
389
| if build_and_host_options and build_and_host_options[0].startswith('--build='): | ||
| self.platform_lib = build_and_host_options[0].split('=', 1)[1] |
There was a problem hiding this comment.
Suggested change
| if build_and_host_options and build_and_host_options[0].startswith('--build='): | |
| self.platform_lib = build_and_host_options[0].split('=', 1)[1] | |
| build_type_option = [x for x in build_and_host_options if x.startswith('--build=')] | |
| if len(build_type_option) == 1: | |
| self.platform_lib = build_type_option[0].split('=', 0) |
make this a bit more robust? or alternatively, let determine_build_and_host_options() return both build and host type options as separate variables?
There was a problem hiding this comment.
Good point, it was meant to be implicit as suggested by the name but explicit is better: 7dc3d2c
akesandgren
reviewed
May 4, 2020
|
Going in, thanks @Flamefire! |
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building of some older GCCs (tried 4.4) fails on e.g. Power due to config.guess being to old.
This is a solved problem in ConfigureMake by using an up-to-date one but GCC EB didn't use it yet as it doesn't call the super-configure method.
Additonally it ignores the build_type and host_type EC variables.
This is fixed with this PR by factoring out a method from ConfigureMake which can then be called by GCC