fix failing sanity check for GCCcore 5.x + sanity check under --module-only for all GCCcore versions #2059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #2033 broken the sanity check for
GCCcore-5.3.0.eb
,GCCcore-5.4.0.eb
,GCCcore-5.5.0.eb
(while older versions likeGCCcore-4.9.3.eb
and newer versions are still fine):The issue is that even though the updated
config.guess
suggests that thex86_64-pc-linux-gnu
should be used, theGCCcore
installation still hasx86_64-unknown-linux-gnu
.In addition, it made the problem with
--module-only
worse, since rather than just having a failing sanity check (see #1588), the GCC easyblock now produces a hard crash becauseself.platform_lib
is never defined when using--module-only
:I've fixed both issues by slightly loosening up the sanity check in the
GCC
easyblock w.r.t. the "configuration name" subdirectory, which was already the proposed solution in #1588 .We don't really care what this directory is called, just that it's there.
This allows us to drop the use of
self.platform_lib
entirely.The updated
config.guess
(result of the changes in #2033) is still used by the GCC build process internally, so that's basically left untouched (we just don't useconfig.guess
ourselves anymore now).fixes #1588