Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom easyblock for AOCC #2295

Merged

Conversation

SebastianAchilles
Copy link
Member

@SebastianAchilles SebastianAchilles commented Dec 27, 2020

(created using eb --new-pr)

EasyBlock for AOCC:

Some of the paths in the sanity_check depend on the version of Clang that AOCC is based on. I have added a custom parameter clangversion. If this is not set in the easyconfig, it tries to find the clangverison in the mapping from AOCC version to Clang version map_aocc_to_clang_ver which is hardcoded in the EasyBlock. I am not sure if that is the best solution. An alternative would either be to remove the check for the paths that contain clangversion, or use an wildcard (is this possible?).

Can be tested with easybuilders/easybuild-easyconfigs#11868

@boegel boegel added the new label Dec 28, 2020
@boegel boegel added this to the next release (4.3.3?) milestone Dec 28, 2020
@boegel boegel changed the title new easyblock for aocc add custom easyblock for AOCC Dec 28, 2020
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small additional code style suggestion: we often use single quotes for string values that don't have spaces, and double quotes for string values that do have spaces.

You're doing it exactly reversed in sanity_check_step, which throws me off a bit.

We don't strictly enforce this, but if you're up for it, please change...

easybuild/easyblocks/a/aocc.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/aocc.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/aocc.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/aocc.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/aocc.py Outdated Show resolved Hide resolved
easybuild/easyblocks/a/aocc.py Outdated Show resolved Hide resolved
…; one command per line for custom commands in sanity check; cleaner update of guesses for module
@easybuilders easybuilders deleted a comment from boegelbot Dec 29, 2020
@boegel
Copy link
Member

boegel commented Dec 29, 2020

Tested with easybuilders/easybuild-easyconfigs#11868, works like a charm, thanks @SebastianAchilles!

@boegel boegel merged commit a90af51 into easybuilders:develop Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants