-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom easyblock for AOCC #2295
add custom easyblock for AOCC #2295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small additional code style suggestion: we often use single quotes for string values that don't have spaces, and double quotes for string values that do have spaces.
You're doing it exactly reversed in sanity_check_step
, which throws me off a bit.
We don't strictly enforce this, but if you're up for it, please change...
…; one command per line for custom commands in sanity check; cleaner update of guesses for module
Tested with easybuilders/easybuild-easyconfigs#11868, works like a charm, thanks @SebastianAchilles! |
(created using
eb --new-pr
)EasyBlock for AOCC:
check_accepted_eula
from add support for --accept-eula configuration option + 'accept_eula' easyconfig parameter easybuild-framework#3535sanity_check_step
is based on https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/c/clang.py as AOCC is based on ClangSome of the paths in the
sanity_check
depend on the version of Clang that AOCC is based on. I have added a custom parameterclangversion
. If this is not set in the easyconfig, it tries to find the clangverison in the mapping from AOCC version to Clang versionmap_aocc_to_clang_ver
which is hardcoded in the EasyBlock. I am not sure if that is the best solution. An alternative would either be to remove the check for the paths that containclangversion
, or use an wildcard (is this possible?).Can be tested with easybuilders/easybuild-easyconfigs#11868