Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check for accepted EULA in custom easyblock for NVHPC #2311

Merged
merged 1 commit into from
Jan 20, 2021
Merged

add check for accepted EULA in custom easyblock for NVHPC #2311

merged 1 commit into from
Jan 20, 2021

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Jan 17, 2021 •
edited
Loading

@lexming lexming mentioned this pull request Jan 18, 2021
Merged
@boegel boegel changed the title add check_accepted_eula to NVHPC easyblock add check for accepted EULA in custom easyblock for NVHPC Jan 20, 2021
boegel
boegel approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.3.3?) milestone Jan 20, 2021
@boegel
Copy link
Member

boegel commented Jan 20, 2021

lgtm, going in

cc @AndiH

@boegel boegel merged commit ef50459 into easybuilders:develop Jan 20, 2021
@lexming lexming deleted the nvhpc-eula branch January 22, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lexming @boegel