-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{compiler}[GCCcore/9.3.0] Add NVHPC v20.9, v20.11 and default to accept EULA #11920
Conversation
This update also enabled automatic downloads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndiH could you also add the source_urls
and comment about the EULA in v20.11 to the easyconfig of v20.9?
I also have a minor suggestion to reduce duplicate code in the easyconfig and make it more readable. Please see below
@AndiH W.r.t. the EULA, we could enhance the NVHPC easyblock to use the |
@boegel We could! But since we got the general ok, I'd suggest to rather always accept it! |
I've added the following changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndiH thanks for updating the PR. I made the changes requested by @boegel to the easyblock of NVHPC (see easybuilders/easybuild-easyblocks#2311) to better handle the acceptance of the EULA.
Since you already checked that the EULA of NVHPC can be automatically accepted by just downloading the sources, we can add accept_eula = True
to these easyconfigs to automatize the process. See below
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
Co-authored-by: Alex Domingo <alex.domingo.toro@vub.be>
Oh, sorry, I didn't recognize there was additional work for me to be done :). It's done now! |
@boegelbot please test @ generoso |
@verdurin: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 770251818 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @lexming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going in, thanks @AndiH ! |
This pull request adds NVHPC 20.11, starting off of #11694.
Additionally, I got approval from @samcmill to default-accept the EULA and have, hence, uncommented the
source_urls
definition. I added a comment relating to the EULA, though.