Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Boost easyblock #2513

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Simplify Boost easyblock #2513

merged 4 commits into from
Aug 25, 2021

Conversation

Flamefire
Copy link
Contributor

Followup to #2456
This now saves some work by building Boost.MPI with the main build and
installing directly into the final folder without an intermediate copy step
Also a bit of cleanup, fixing comments, ...

@Flamefire
Simplify Boost easyblock
13a07d0 
Followup to easybuilders#2456
This now saves some work by building Boost.MPI with the main build and
installing directly into the final folder without an intermediate copy
step
Also a bit of cleanup, fixing comments, ...
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

  • SUCCESS Boost-1.72.0-GCCcore-9.3.0-no_mpi.eb
  • SUCCESS Boost-1.71.0-gompic-2019b.eb
  • SUCCESS Boost-1.70.0-gompic-2019a.eb
  • SUCCESS Boost-1.68.0-foss-2018b-Python-3.6.6.eb
  • SUCCESS Boost-1.54.0-foss-2016b-Python-2.7.12.eb
  • SUCCESS Boost.Python-1.64.0-gompi-2019a.eb
  • SUCCESS Boost.Python-1.67.0-foss-2018b-Python-3.6.6.eb
  • SUCCESS Boost.Python-1.74.0-GCC-10.2.0.eb

Build succeeded for 8 out of 8 (8 easyconfigs in total)
taurusi6605.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/0339ff0adee6acf39822e985d96db197 for a full test report.

@Flamefire Flamefire mentioned this pull request Jul 15, 2021
Merged
@Flamefire
Copy link
Contributor Author

@branfosj @akesandgren Any comments?

@migueldiascosta migueldiascosta added this to the next release (4.4.2?) milestone Jul 17, 2021
akesandgren
akesandgren approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @Flamefire!

@akesandgren akesandgren merged commit b3c8475 into easybuilders:develop Aug 25, 2021
@Flamefire Flamefire deleted the boost_mpi branch August 30, 2021 09:22
@boegel boegel added the change label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
change enhancement
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Flamefire @akesandgren @boegel @migueldiascosta