Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{devel}[GCC/10.3.0,intel-compilers/2021.2.0] Boost v1.76.0 #12977

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

boegel
Copy link
Member

@boegel boegel commented May 28, 2021

(created using eb --new-pr)

@boegel boegel added the update label May 28, 2021
@boegel
Copy link
Member Author

boegel commented May 28, 2021

@boegelbot please test @ generoso

@boegel boegel added this to the 4.4.0 milestone May 28, 2021
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12977 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12977 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17313

Test results coming soon (I hope)...

- notification for comment with ID 850219075 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented May 28, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2619.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2c8cd83f162256fa693f71944bceaa32 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 28, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/5084659d4b47b7a38b092cebc803abe1 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 28, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
select-pika-c6gd-2xlarge-0001 - Linux centos linux 8.3.2011, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/dc6041773906eb61099c7d0b977ef4f2 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-x-3 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b030b7680cc459ac95a2594c813af6f3 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 28, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild2.novalocal - Linux centos linux 8.3.2011, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/5cf91ede1dcc3da6ce949226e4ca684c for a full test report.

@boegel boegel requested a review from verdurin May 28, 2021 09:51
@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 1 out of 3 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/77e6dd6e091c73797d180406f79cdd07 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 2 out of 3 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/8638095d528b3c964ba7760dd4361b0f for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
nuc.lan - Linux Fedora 33, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.9.4
See https://gist.github.com/1d04358f5eacf7b0492baedf1fc94a28 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 1 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/54ccd9edbb1f9f9dc91fd881aedf5f57 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 1 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/d2ba0dff34a17cee151c1310968601e0 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 28, 2021

@verdurin The failing tests boil down to now having glibc-static installed, right?
Are existing Boost-1.74.0-GCC-10.2.0.eb easyconfigs working as expected on that same system?

@verdurin
Copy link
Member

As far as I know they are. Note it fails on two different build nodes - Fedora 33 and CentOS 7.

@boegel boegel modified the milestones: 4.4.0, release after 4.4.0 May 29, 2021
@Flamefire
Copy link
Contributor

Flamefire commented Jun 1, 2021

We need to address 2 issues:

  1. The Boost-cmake config files do not work because we build with tagged and system layout where only threading differs, which is ignored (by the config files) for system and hence it tries to use 2 lib files for the same boost lib: Target Boost::system already has an imported location
  2. We don't build a single-thread Boost, but multithreaded twice which is pointless

--

  1. can be workarounded by find $EBROOTBOOST/lib/cmake -name '*variant-shared.cmake' -delete but that is not nice

The best approach (for all Boost versions) is to either only build system layout or build tagged with threading=single,multi and optionally add symlinks for the non-tagged versions to either the single- or multi-threaded versions.

Note that threading=multi was the default since at least Boost 1.47, maybe forever.

@akesandgren
Copy link
Contributor

If we build both single and multi then default should probably be single, that will cause the least issues with other codes that themselves use threading and/or OpenMP.

@Flamefire
Copy link
Contributor

If we build both single and multi then default should probably be single, that will cause the least issues with other codes that themselves use threading and/or OpenMP.

The default of Boot is multi and AFAIK this "only" means that it is thread-safe, i.e. uses locking and such. So no I wouldn't choose single as the default

@verdurin
Copy link
Member

verdurin commented Jun 7, 2021

Could someone summarise where we are with this one now?

@Flamefire
Copy link
Contributor

@verdurin Basically waiting for easybuilders/easybuild-easyblocks#2456 (and a smaller follow-up I'll do afterwards)

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/1c63ee88f696f416cf7062e415710fa5 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/496a33236db1e5c46497beed49bf1122 for a full test report.

@Flamefire
Copy link
Contributor

@boegel Simply add a sed on tools/build/src/engine/build.sh to delete -static

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion from @Flamefire works for me.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@branfosj
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on generoso

PR test command 'EB_PR=12977 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12977 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 17780

Test results coming soon (I hope)...

- notification for comment with ID 880177453 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/f8816666c0a70821da097a96cf9476ca for a full test report.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy changes due to update to easyblock

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/12b75c0a5cff6bf0c3b55a16ad89c9d7 for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u16a.bear.cluster - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/d91850552a0be19589e7c7eb63dcd733 for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0306u07a.bear.cluster - Linux RHEL 8.4, POWER, 8335-GTX (power9le), Python 3.6.8
See https://gist.github.com/54c4bfde183a492fd2889cd4e74cf3c9 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
generoso-c1-s-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c27525cd06c550dbf914a5dd42d8958a for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bber0501u03b.bb2.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/a80f7cf5e2b4e873d868c63920986f15 for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2513
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.3, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/2b2693f4bbb8ff7a2c315e5c450776eb for a full test report.

@Flamefire
Copy link
Contributor

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2513
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
taurusi6607.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/9c3c1485a54c3d48101a02d257b392b4 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
rocky8-eb - Linux rocky linux 8.4, x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.6.8
See https://gist.github.com/91df8a3cd38e0dc5efc28e12d0bada0a for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
centos8-eb - Linux centos linux 8.3.2011, x86_64, Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (skylake), Python 3.6.8
See https://gist.github.com/51c6a733eb7e8056ea3816922e7cc11d for a full test report.

@smoors
Copy link
Contributor

smoors commented Jul 15, 2021

Test report by @smoors
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node361.hydra.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 2.7.5
See https://gist.github.com/00af156198fe26c26099b0b45404253c for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
ebvm.novalocal - Linux centos linux 8.3.2011, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/8f34ce00a6ea40b0dcc1a25590d5a53a for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Jul 15, 2021

Going in, thanks @boegel!

@smoors smoors merged commit 74ff6f5 into easybuilders:develop Jul 15, 2021
@boegel boegel deleted the 20210528093936_new_pr_Boost1760 branch August 7, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants