-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{devel}[GCC/10.3.0,intel-compilers/2021.2.0] Boost v1.76.0 #12977
{devel}[GCC/10.3.0,intel-compilers/2021.2.0] Boost v1.76.0 #12977
Conversation
…mpilers-2021.2.0.eb
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 850219075 processed Message to humans: this is just bookkeeping information for me, |
…ntel-compilers toolchain
Test report by @boegel |
Test report by @boegel |
Test report by @boegel |
Test report by @boegelbot |
Test report by @boegel |
Test report by @verdurin |
Test report by @verdurin |
Test report by @verdurin |
Test report by @verdurin |
Test report by @verdurin |
@verdurin The failing tests boil down to now having |
As far as I know they are. Note it fails on two different build nodes - Fedora 33 and CentOS 7. |
We need to address 2 issues:
--
The best approach (for all Boost versions) is to either only build system layout or build tagged with Note that |
If we build both single and multi then default should probably be single, that will cause the least issues with other codes that themselves use threading and/or OpenMP. |
The default of Boot is multi and AFAIK this "only" means that it is thread-safe, i.e. uses locking and such. So no I wouldn't choose single as the default |
Could someone summarise where we are with this one now? |
@verdurin Basically waiting for easybuilders/easybuild-easyblocks#2456 (and a smaller follow-up I'll do afterwards) |
Test report by @boegelbot |
Test report by @boegelbot |
@boegel Simply add a sed on tools/build/src/engine/build.sh to delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion from @Flamefire works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding ICU, as per @akesandgren comment at https://github.com/easybuilders/easybuild-easyconfigs/pull/12977/files#r643702476
Co-authored-by: SebastianAchilles <achilles@aices.rwth-aachen.de>
@boegelbot please test @ generoso |
@branfosj: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 880177453 processed Message to humans: this is just bookkeeping information for me, |
Test report by @branfosj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy changes due to update to easyblock
easybuild/easyconfigs/b/Boost/Boost-1.76.0-intel-compilers-2021.2.0.eb
Outdated
Show resolved
Hide resolved
Test report by @branfosj |
Test report by @branfosj |
Test report by @branfosj |
Test report by @boegelbot |
Test report by @branfosj |
Test report by @branfosj |
Test report by @Flamefire |
Test report by @SebastianAchilles |
Test report by @SebastianAchilles |
Test report by @smoors |
Test report by @SebastianAchilles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @boegel! |
(created using
eb --new-pr
)