-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak Amber(Tools) easyblock to run tests from top-level directory #2781
tweak Amber(Tools) easyblock to run tests from top-level directory #2781
Conversation
Don't merge yet. Looks like we need some patches in AT 21 and older to be able to do this. |
@akesandgren Can you explain these changes a bit more? Why the change to |
That code path is only used for AmberTools 20 (and thus Amber 20) and higher. Running the tests from the top dir is the correct way to run tests according to the developers. Thus this change makes the tests not run any pmemd tests when just building AmberTools whivch was the problem before. (There are still tests in the suites that fail, but I'm chasing the developers to get better (less exact) testing of those reesults) One still have to check the test logs for details but at least we get a working test log. |
Should be good to merge now in my opinion, updated PR's for relevant AmberTools versions submitted. Current Amber easyconfigs not affected since they aren't currently running the tests. (Except one that will need the top level Makefile patch to not include config.h) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(created using
eb --new-pr
)