Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix top level Makefile for AmberTools 20 and enable tests #16150

Merged

Conversation

akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Aug 29, 2022

(created using eb --new-pr)

Depends on easybuilders/easybuild-easyblocks#2781

@akesandgren akesandgren added this to the 4.x milestone Aug 29, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 30, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2022
@akesandgren
Copy link
Contributor Author

@boegelbot Please test @ generoso

@boegelbot
Copy link
Collaborator

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=16150 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16150 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9093

Test results coming soon (I hope)...

- notification for comment with ID 1232794918 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/16f368b42dffba4d55bdb8b0df5a848e for a full test report.

@boegel boegel changed the title fix top level Makefile for AmberTools 20 fix top level Makefile for AmberTools 20 and enable tests Sep 10, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Sep 10, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (1 easyconfigs in total)
node3114.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/aafd71f660c3e4ba55d76d3d4bcb4e7e for a full test report.

@boegel
Copy link
Member

boegel commented Sep 10, 2022

Going in, thanks @akesandgren!

@boegel boegel merged commit b97e7f3 into easybuilders:develop Sep 10, 2022
@akesandgren akesandgren deleted the 20220829131116_new_pr_AmberTools20 branch September 12, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants