Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sanity check for OpenFOAM 11 #2978

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Aug 7, 2023

(created using eb --new-pr)

In OpenFOAM/OpenFOAM-dev@968e601 OpenFOAM combined some solvers.

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@ocaisa
Copy link
Member

ocaisa commented Aug 7, 2023

Test report by @ocaisa

Overview of tested easyconfigs (in order)

  • SUCCESS OpenFOAM-9-foss-2021a.eb
  • SUCCESS OpenFOAM-10-foss-2022a.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
login1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz, Python 3.6.8
See https://gist.github.com/ocaisa/caa8825fc9dca08d75eba42e7a3c8903 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Aug 8, 2023

Test for OpenFoam 11 is in easybuilders/easybuild-easyconfigs#18475

@ocaisa ocaisa merged commit 2eeb5ef into easybuilders:develop Aug 8, 2023
@branfosj branfosj deleted the 20230807144028_new_pr_openfoam branch August 8, 2023 07:50
@boegel boegel added the update label Aug 8, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 8, 2023
# both removed in version 11
if self.looseversion < LooseVersion("11"):
tools.append("buoyantFoam")
tools.append("reactingFoam")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity: isn't there another (replacement) solver we can check for instead with OpenFOAM 11+?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants