Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sanity check for OpenFOAM 11 #2978

Merged
merged 1 commit into from
Aug 8, 2023
Merged

update sanity check for OpenFOAM 11 #2978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions easybuild/easyblocks/o/openfoam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,14 +438,14 @@ def sanity_check_step(self):
if self.is_dot_org and self.looseversion >= LooseVersion('7'):
tools.remove("buoyantBoussinesqSimpleFoam")
tools.remove("sonicFoam")
# buoyantSimpleFoam replaced by buoyantFoam in versions 10+
if self.is_dot_org and self.looseversion >= LooseVersion("10"):
# engineFoam replaced by reactingFoam and buoyantSimpleFoam replaced by buoyantFoam in version 10
if self.is_dot_org and LooseVersion("10") <= self.looseversion:
tools.remove("buoyantSimpleFoam")
tools.append("buoyantFoam")
# engineFoam replaced by reactingFoam in versions 10+
if self.is_dot_org and self.looseversion >= LooseVersion("10"):
tools.remove("engineFoam")
tools.append("reactingFoam")
# both removed in version 11
if self.looseversion < LooseVersion("11"):
tools.append("buoyantFoam")
tools.append("reactingFoam")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity: isn't there another (replacement) solver we can check for instead with OpenFOAM 11+?


bins = [os.path.join(self.openfoamdir, "bin", x) for x in ["paraFoam"]] + \
[os.path.join(toolsdir, x) for x in tools]
Expand Down