Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace run_cmd with run_shell_cmd in custom easyblock for imkl (imkl.py) #3122

Merged
merged 1 commit into from
Feb 9, 2024
Merged

replace run_cmd with run_shell_cmd in custom easyblock for imkl (imkl.py) #3122

merged 1 commit into from
Feb 9, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jan 31, 2024 •
edited
Loading

(created using eb --new-pr)

  • EB_imkl used in imkl_fftw
  • No use of EB_imkl in easyconfigs

@branfosj branfosj mentioned this pull request Jan 31, 2024
Closed
@branfosj branfosj added this to the 5.0 milestone Jan 31, 2024
@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-2024.0.0.eb
  • SUCCESS imkl-2023.0.0.eb
  • SUCCESS imkl-2022.0.1.eb
  • SUCCESS imkl-2021.2.0-iimpi-2021a.eb

Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/8356a5ede741bf888bedd974ef8ce819 for a full test report.

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-FFTW-2024.0.0-iimpi-2023.11.eb
  • SUCCESS imkl-FFTW-2022.2.1-iimpi-2022b.eb
  • SUCCESS imkl-FFTW-2021.4.0-gompi-2021b.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/b821383be6f090c0ea06e46c8652d6f1 for a full test report.

jfgrimm
jfgrimm approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit d2226c9 into easybuilders:5.0.x Feb 9, 2024
17 checks passed
@branfosj branfosj deleted the 20240131181405_new_pr_imkl branch February 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees
No one assigned
Labels
change EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @jfgrimm